From c7675ca8bbc86309b9a019103c0bb03ed3062d62 Mon Sep 17 00:00:00 2001
From: Ogi Moore <ognyan.moore@gmail.com>
Date: Sun, 30 May 2021 21:29:24 -0700
Subject: [PATCH] Fix unraisable exception in test_examples

The way we called subprocess.Popen, it looks like we didn't close all
the pipes; this PR addresses the warning that pytest generates when
running the examples.

In addition, we toggle the pytest setting to error on any warning
---
 examples/test_examples.py | 58 +++++++++++++++++++--------------------
 pytest.ini                |  1 +
 2 files changed, 29 insertions(+), 30 deletions(-)

diff --git a/examples/test_examples.py b/examples/test_examples.py
index a4a51455..e370f0db 100644
--- a/examples/test_examples.py
+++ b/examples/test_examples.py
@@ -1,16 +1,13 @@
-# -*- coding: utf-8 -*-
-from __future__ import print_function, division, absolute_import
 from collections import namedtuple
 from pyqtgraph import Qt
-
 import errno
+import time
 import importlib
 import itertools
 import pytest
 import os, sys
 import platform
 import subprocess
-import time
 from argparse import Namespace
 if __name__ == "__main__" and (__package__ is None or __package__==''):
     parent_dir = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
@@ -143,13 +140,11 @@ conditionalExamples = {
     ]
 )
 def testExamples(frontend, f):
-    # runExampleFile(f[0], f[1], sys.executable, frontend)
-
     name, file = f
     global path
     fn = os.path.join(path, file)
     os.chdir(path)
-    sys.stdout.write("{} ".format(name))
+    sys.stdout.write(f"{name}")
     sys.stdout.flush()
     import1 = "import %s" % frontend if frontend != '' else ''
     import2 = os.path.splitext(os.path.split(fn)[1])[0]
@@ -172,24 +167,19 @@ except:
     raise
 
 """.format(import1, import2)
-    if sys.platform.startswith('win'):
-        process = subprocess.Popen([sys.executable],
-                                    stdin=subprocess.PIPE,
-                                    stderr=subprocess.PIPE,
-                                    stdout=subprocess.PIPE)
-    else:
-        process = subprocess.Popen(['exec %s -i' % (sys.executable)],
-                                   shell=True,
-                                   stdin=subprocess.PIPE,
-                                   stderr=subprocess.PIPE,
-                                   stdout=subprocess.PIPE)
-    process.stdin.write(code.encode('UTF-8'))
+    process = subprocess.Popen([sys.executable],
+                                stdin=subprocess.PIPE,
+                                stderr=subprocess.PIPE,
+                                stdout=subprocess.PIPE,
+                                text=True)
+    process.stdin.write(code)
     process.stdin.close()
+
     output = ''
     fail = False
     while True:
         try:
-            c = process.stdout.read(1).decode()
+            c = process.stdout.read(1)
         except IOError as err:
             if err.errno == errno.EINTR:
                 # Interrupted system call; just try again.
@@ -197,7 +187,6 @@ except:
             else:
                 raise
         output += c
-
         if output.endswith('test complete'):
             break
         if output.endswith('test failed'):
@@ -210,16 +199,25 @@ except:
         if time.time() - start > 2.0 and not killed:
             process.kill()
             killed = True
-    #res = process.communicate()
-    res = (process.stdout.read(), process.stderr.read())
+
+    stdout, stderr = (process.stdout.read(), process.stderr.read())
+    process.stdout.close()
+    process.stderr.close()
+
     if (fail or
-        'exception' in res[1].decode().lower() or
-        'error' in res[1].decode().lower()):
-        print(res[0].decode())
-        print(res[1].decode())
-        pytest.fail("{}\n{}\nFailed {} Example Test Located in {} "
-            .format(res[0].decode(), res[1].decode(), name, file),
-            pytrace=False)
+        'exception' in stderr.lower() or
+        'error' in stderr.lower()):
+        if (not fail 
+            and name == "RemoteGraphicsView" 
+            and "pyqtgraph.multiprocess.remoteproxy.ClosedError" in stderr):
+            # This test can intermittently fail when the subprocess is killed
+            return None
+        print(stdout)
+        print(stderr)
+        pytest.fail(
+            f"{stdout}\n{stderr}\nFailed {name} Example Test Located in {file}",
+            pytrace=False
+        )
 
 if __name__ == "__main__":
     pytest.cmdline.main()
diff --git a/pytest.ini b/pytest.ini
index cdf2e422..b09221c1 100644
--- a/pytest.ini
+++ b/pytest.ini
@@ -7,6 +7,7 @@ xvfb_args=-ac +extension GLX +render
 faulthandler_timeout = 60
 
 filterwarnings =
+    error
     # re-enable standard library warnings
     once::DeprecationWarning
     once::PendingDeprecationWarning