2021-01-26 13:19:34 -05:00
|
|
|
The ctests are not convenient tests. In this file we can attempt to log the
|
|
|
|
|
benefits and costs to using them so we can periodically evaluate which tests we
|
|
|
|
|
should keep and which we should get rid of.
|
|
|
|
|
|
|
|
|
|
Below are some objective costs:
|
|
|
|
|
|
|
|
|
|
- The time it takes to run the ctests.
|
|
|
|
|
- The email discussion back-and-forth.
|
|
|
|
|
|
|
|
|
|
There are also some non-objective costs. The ctests are annoying and not fun to
|
|
|
|
|
maintain, discuss, and fix. Although it's hard to measure this "annoyance"
|
|
|
|
|
cost, it should be taken into account when we review.
|
|
|
|
|
|
|
|
|
|
Below we can try to keep a log of which bugs are found with which ctests. This
|
|
|
|
|
way we can see which tests are the most useful. It is difficult to objectively
|
|
|
|
|
differentiate between minor bugs and important bugs.
|
2021-01-26 13:28:41 -05:00
|
|
|
|
2021-06-21 12:57:38 -04:00
|
|
|
The "Benefit" row gives the amount of days in-between when an issue is found
|
|
|
|
|
because of the ctests and when an issue is reported by someone not using the
|
|
|
|
|
ctests.
|
|
|
|
|
|
2022-02-16 22:05:02 -05:00
|
|
|
The "ctest" row gives a ctest pattern for the tests that were affected by the
|
|
|
|
|
regression.
|
|
|
|
|
|
2021-01-28 00:14:37 -05:00
|
|
|
Examples where convergence tests took time and annoyance to figure out that
|
|
|
|
|
they were actually "false positives" (i.e., no bug that is worth the time or
|
|
|
|
|
complexity to fix):
|
2021-01-26 13:28:41 -05:00
|
|
|
|
|
|
|
|
https://www.mail-archive.com/search?l=mid&q=20210125200655.e27xaaoy2belyxhw%40tallinn
|
2021-01-28 00:25:30 -05:00
|
|
|
|
|
|
|
|
|
2021-03-06 20:09:32 -05:00
|
|
|
Examples where bugs were fixed (more quickly) because of ctests:
|
2021-01-28 00:25:30 -05:00
|
|
|
|
|
|
|
|
Report : https://www.mail-archive.com/search?l=mid&q=20210126190837.pwuxhrhrikzszfrh%40tallinn
|
|
|
|
|
Fix : 92f8612a
|
2021-01-28 11:59:41 -05:00
|
|
|
|
|
|
|
|
Report : https://www.mail-archive.com/search?l=mid&q=b0a33192bc5635bd1cb5596e346f9c34615ffeb4.camel%40lyx.org
|
|
|
|
|
Fix : ab1d418f
|
2021-02-05 22:45:14 -05:00
|
|
|
|
|
|
|
|
Fix : ef2b2827
|
2021-02-08 00:13:45 -05:00
|
|
|
|
|
|
|
|
Fix : 1ddc1c6b
|
2021-02-19 19:19:12 -05:00
|
|
|
|
|
|
|
|
Report : https://www.mail-archive.com/search?l=mid&q=20210218051838.jbwnemfv5ilhlsls%40tallinn
|
|
|
|
|
Fix : 358e4ace
|
2021-03-06 20:09:24 -05:00
|
|
|
|
|
|
|
|
Fix : 3df42924
|
2021-04-10 12:17:16 -04:00
|
|
|
|
|
|
|
|
Fix : 67d0b80f
|
2021-04-23 23:55:13 -04:00
|
|
|
|
|
|
|
|
Fix : 8ce6c815
|
2021-05-26 01:20:45 -04:00
|
|
|
|
|
|
|
|
Report : https://www.mail-archive.com/search?l=mid&q=20210523014926.xewdr5x62br2okvy%40tallinn
|
|
|
|
|
Fix : 39a9e370
|
2021-05-28 10:35:26 -04:00
|
|
|
|
|
|
|
|
Report : https://www.mail-archive.com/search?l=mid&q=20210528001413.56phju7dvfn4dexs%40tallinn
|
|
|
|
|
Fix : ffa6a724
|
2021-06-20 00:05:42 -04:00
|
|
|
|
2021-06-21 12:56:37 -04:00
|
|
|
Report : https://www.mail-archive.com/search?l=mid&q=20210529174524.idnmt5w4tvhuvyy6%40tallinn
|
|
|
|
|
Note1 : We are still not sure what to do regarding how to make it more user-friendly
|
|
|
|
|
for users to realize that "-dALLOWPSTRANSPARENCY" is needed for the ps2pdf converter.
|
2021-06-21 12:57:38 -04:00
|
|
|
Benefit: 14 days (https://www.lyx.org/trac/ticket/12303)
|
2021-06-21 12:56:37 -04:00
|
|
|
|
2021-12-05 22:07:06 -05:00
|
|
|
Report : https://www.mail-archive.com/search?l=mid&q=20211205190238.edrtqmg3fkdr7gbo%40poole
|
|
|
|
|
Fix : 489bf46a, e3489d54
|
|
|
|
|
|
2022-02-06 08:13:12 -05:00
|
|
|
Report : https://www.mail-archive.com/search?l=mid&q=20220205184128.4clckanaufwmx5z4%40gary
|
|
|
|
|
Fix : d66c27de
|
|
|
|
|
|
2022-02-07 22:13:37 -05:00
|
|
|
Report : https://www.mail-archive.com/search?l=mid&q=20220206142559.rpgwki7wruhtasxp%40gary
|
|
|
|
|
Fix : f71f71d0
|
|
|
|
|
|
2022-03-12 07:41:00 -05:00
|
|
|
Report : https://www.mail-archive.com/search?l=mid&q=20220310131706.qdthdjblfpme2wew%40gary
|
|
|
|
|
Fix : dc502c82
|
|
|
|
|
ctests : examples/Welcome_pdf2
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2021-06-20 00:05:42 -04:00
|
|
|
|
|
|
|
|
Examples where upstream (e.g., LaTeX packages) bugs were fixed (more quickly)
|
|
|
|
|
because of ctests:
|
|
|
|
|
|
|
|
|
|
Fix : https://github.com/nrnrnr/noweb/pull/12#event-4892099481
|
2021-12-07 13:03:39 -05:00
|
|
|
|
|
|
|
|
Report : (private message to Jürgen: Message-ID:<20211205192054.zbxij5butj3wdyvf@poole>)
|
|
|
|
|
Fix : some of the polyglossia commits in the range 1c36dcdc^...bf69288c
|
|
|
|
|
Benefit: Not clear. The regressions were in the development version so they
|
|
|
|
|
could have easily been caught before release.
|
2021-12-08 23:03:43 -05:00
|
|
|
|
|
|
|
|
Report : https://www.mail-archive.com/search?l=mid&q=20211207200100.o27ojaftehrjfcza%40poole
|
|
|
|
|
Fix : 2eaf30c5
|
2022-02-16 22:05:02 -05:00
|
|
|
|
|
|
|
|
|
|
|
|
|
Report : (private message to Jürgen: LyXMessage-ID:<20220216020703.la2fd5gu7yz7y7dc@gary>)
|
|
|
|
|
Fix : https://github.com/reutenauer/polyglossia/commit/c7489ebaf8c66a7e4fe2529de7068ebb79c68812
|
|
|
|
|
Benefit: Not clear. The regressions were in the development version so they
|
|
|
|
|
could have easily been caught before release.
|
|
|
|
|
ctests : export/export/lyx2lyx/revert-languages-polyglossia-primary_lyx22
|
