anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-11-22 01:59:02 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix bug #9907: We get a crash if we first close a master buffer one of

Browse Source 
whose children is also a child of another buffer, then try to close that
one.

The problem is that we do not check properly to make sure that the child
is not a child of some other buffer. Now we do.
This commit is contained in:
Richard Heck 2016-01-05 09:53:42 -05:00
parent e8ffb0c97a
commit 0407364392
1 changed files with 17 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/frontends/qt4/GuiView.cpp
View File

@ -2849,23 +2849,31 @@ bool GuiView::closeBuffer(Buffer & buf)
ListOfBuffers::const_iterator it = clist.begin();
ListOfBuffers::const_iterator const bend = clist.end();
for (; it != bend; ++it) {
// If a child is dirty, do not close
// without user intervention
//FIXME: should we look in other tabworkareas?
Buffer * child_buf = *it;
if (theBufferList().isOthersChild(&buf, child_buf)) {
child_buf->setParent(0);
continue;
}
// FIXME: should we look in other tabworkareas?
// ANSWER: I don't think so. I've tested, and if the child is
// open in some other window, it closes without a problem.
GuiWorkArea * child_wa = workArea(*child_buf);
if (child_wa) {
if (!closeWorkArea(child_wa, true)) {
success = false;
success = closeWorkArea(child_wa, true);
if (!success)
break;
}
} else
theBufferList().releaseChild(&buf, child_buf);
} else {
// In this case the child buffer is open but hidden.
// It therefore should not (MUST NOT) be dirty!
LATTEST(child_buf->isClean());
theBufferList().release(child_buf);
}
}
}
if (success) {
// goto bookmark to update bookmark pit.
//FIXME: we should update only the bookmarks related to this buffer!
// FIXME: we should update only the bookmarks related to this buffer!
LYXERR(Debug::DEBUG, "GuiView::closeBuffer()");
for (size_t i = 0; i < theSession().bookmarks().size(); ++i)
guiApp->gotoBookmark(i+1, false, false);