anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-12-22 13:18:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add comment that a code chunk is unnecessary

Browse Source 
A chunk of code in an event handler seems to be unnecessary to me
because the event that the situation handles never makes it this far
in the event handling hierarchy. I'm not sure why this is, and thus
I'm not sure if this is true in all cases (e.g. Qt version) and if
it will be true in the future so I leave this code for now.
This commit is contained in:
Scott Kostyshak 2016-07-21 19:14:16 -04:00
parent 71374b38c2
commit 07be240ebe
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/frontends/qt4/GuiWorkArea.cpp
View File

@ -1633,6 +1633,12 @@ void TabWorkArea::mouseDoubleClickEvent(QMouseEvent * event)
if (event->button() != Qt::LeftButton)
return;
// this code chunk is unnecessary because it seems the event only makes
// it this far if it is not on a tab. I'm not sure why this is (maybe
// it is handled and ended in DragTabBar?), and thus I'm not sure if
// this is true in all cases and if it will be true in the future so I
// leave this code for now. (skostysh, 2016-07-21)
//
// return early if double click on existing tabs
for (int i = 0; i < count(); ++i)
if (tabBar()->tabRect(i).contains(event->pos()))