Some potential bugs spotted by llvm/clang

src/TextClass.h
src/insets/InsetTabular.h

  Overloaded virtual method missing the 'const' qualifier

src/insets/InsetCommandParams.h

  Missing constructor (breaks compilation with llvm/clang)

src/frontends/qt4/GuiWorkArea.cpp

  Missing parenthesis: `+' has priority over `?:' (I do not know
  whether this has a visible effect).

src/mathed/InsetMathFont.cpp

  Use of == instead of = in mathmlize()
This commit is contained in:
Jean-Marc Lasgouttes 2013-05-03 14:15:10 +02:00
parent 699e334671
commit 0c1eb71448
6 changed files with 11 additions and 5 deletions

View File

@ -361,7 +361,7 @@ public:
/// \return true if there is a Layout with latexname lay
bool hasLaTeXLayout(std::string const & lay) const;
/// A DocumentClass nevers count as loaded, since it is dynamic
virtual bool loaded() { return false; }
virtual bool loaded() const { return false; }
/// \return the layout object of an inset given by name. If the name
/// is not found as such, the part after the ':' is stripped off, and
/// searched again. In this way, an error fallback can be provided:

View File

@ -940,7 +940,7 @@ void GuiWorkArea::generateSyntheticMouseEvent()
buffer_view_->scroll(up ? -step : step);
buffer_view_->updateMetrics();
} else {
buffer_view_->scrollDocView(value + up ? -step : step, false);
buffer_view_->scrollDocView(value + (up ? -step : step), false);
}
// In which paragraph do we have to set the cursor ?

View File

@ -31,6 +31,8 @@ class Lexer;
class ParamInfo {
public:
///
ParamInfo() {}
/// Types of parameters
enum ParamType {
LATEX_OPTIONAL, /// normal optional argument

View File

@ -55,7 +55,7 @@ public:
///
InsetCode lyxCode() const { return CELL_CODE; }
///
Inset * clone() { return new InsetTableCell(*this); }
Inset * clone() const { return new InsetTableCell(*this); }
///
bool getStatus(Cursor & cur, FuncRequest const & cmd,
FuncStatus & status) const;

View File

@ -140,7 +140,7 @@ void InsetMathFont::htmlize(HtmlStream & os) const
|| tag == "textbf")
variant = "bold";
else if (tag == "mathcal")
variant == "script";
variant = "script";
else if (tag == "mathit" || tag == "textsl"
|| tag == "emph" || tag == "textit")
variant = "italic";
@ -180,7 +180,7 @@ void InsetMathFont::mathmlize(MathStream & os) const
|| tag == "textbf")
variant = "bold";
else if (tag == "mathcal")
variant == "script";
variant = "script";
else if (tag == "mathit" || tag == "textsl"
|| tag == "emph" || tag == "textit")
variant = "italic";

View File

@ -77,3 +77,7 @@ What's new
* BUILD/INSTALLATION
- Add support for automake 1.13.
- Fix compilation with clang LLVM compiler.