anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2025-01-22 07:42:02 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Avoid duplicate checks in CoordCache

Browse Source 
The code is written in such a way that the elements are searched
several times. This can be expensive when there are a lots of insets
in the document.

Concerning the sanity checks, they are now conditionned on the
presence of assertion.

Related to bug #12297.
This commit is contained in:
Jean-Marc Lasgouttes 2021-10-06 13:06:45 +02:00
parent e5bb491e2e
commit 0fff65a16a
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/CoordCache.h
View File

@ -26,7 +26,7 @@ class MathData;
void lyxbreaker(void const * data, const char * hint, int size);
struct Geometry {
Point pos;
Point pos = {-10000, -10000 };
Dimension dim;
bool covers(int x, int y) const
@ -75,8 +75,6 @@ public:
void add(T const * thing, Dimension const & dim)
{
if (!has(thing))
data_[thing].pos = Point(-10000, -10000);
data_[thing].dim = dim;
}
@ -147,6 +145,7 @@ public:
private:
friend class CoordCache;
#ifdef ENABLE_ASSERTIONS
void checkDim(T const * thing, char const * hint) const
{
if (!hasDim(thing))
@ -158,6 +157,11 @@ private:
if (!has(thing))
lyxbreaker(thing, hint, data_.size());
}
#else
void checkDim(T const *, char const * const ) const {}
void check(T const *, char const *) const {}
#endif
typedef std::unordered_map<T const *, Geometry> cache_type;
cache_type data_;