anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-11-22 10:00:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Tentative fix for the inset problems on Mac (#12418, maybe #12820, #12279)

Browse Source 
This is committed now in order to get testing from Mac users in the next
prerelease. Subject to change or even reversion.
This commit is contained in:
Juergen Spitzmueller 2023-08-21 19:20:06 +02:00
parent 677dc3b7a6
commit 101363352c
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/insets/Inset.cpp
View File

@ -383,6 +383,22 @@ bool Inset::showInsetDialog(BufferView * bv) const
void Inset::doDispatch(Cursor & cur, FuncRequest &cmd) void Inset::doDispatch(Cursor & cur, FuncRequest &cmd)
{ {
switch (cmd.action()) { switch (cmd.action()) {
// FIXME: The LFUN_MOUSE_MOTION case is a potential fix for #12418, and maybe also
// #12820 and #12279. This needs to be tested in the pre-release. Also it might
// add slight regressions with inset selection (when selection starts on the button
// of an inset).
// After this has been tested (by Mac users primarily), this comment should be
// updated if the fix is kept or after it has been modified.
case LFUN_MOUSE_MOTION:
// Do not attempt to select while hovering the inset button only (#12418).
if (!cur.selection() && cmd.button() == mouse_button::button1
&& clickable(cur.bv(), cmd.x(), cmd.y())) {
cur.noScreenUpdate();
cur.dispatched();
} else
cur.undispatched();
break;
case LFUN_MOUSE_RELEASE: case LFUN_MOUSE_RELEASE:
// if the derived inset did not explicitly handle mouse_release, // if the derived inset did not explicitly handle mouse_release,
// we assume we request the settings dialog // we assume we request the settings dialog