anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-11-09 18:31:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix for qt2 citation dialog crash when selecting first key

Browse Source 
of available bibliography keys.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@2135 a592a061-630c-0410-9148-cb99ea01b6c8
This commit is contained in:
Angus Leeming 2001-06-17 13:22:56 +00:00
parent b8105d810f
commit 11d542be6b
4 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/frontends/qt2/ChangeLog
View File

@ -1,3 +1,13 @@
2001-06-17 Angus Leeming <a.leeming@ic.ac.uk>
* FormCitation.C (build): removed bc().refresh() call as the controller
should take care of this.
(update): removed noKeys stuff as you don't use it.
* FormCitationDialogImpl.C (slotBibSelected): Can't select bibkeys[-1]!
We were being bit by the xforms browser returns the browser line number
in Fortran style, but Qt uses C-style.
2001-06-16 Angus Leeming <a.leeming@ic.ac.uk>
* FormCitationDialogImpl.C: added using directive.

7
src/frontends/qt2/FormCitation.C
View File

@ -88,8 +88,6 @@ void FormCitation::build()
bc().addReadOnly(dialog_->citationStyleCO);
bc().addReadOnly(dialog_->textBeforeED);
bc().addReadOnly(dialog_->textAfterED);
bc().refresh();
}
@ -108,11 +106,6 @@ void FormCitation::update()
setBibButtons(OFF);
setCiteButtons(OFF);
int noKeys = int(max(bibkeys.size(), citekeys.size()));
// Place bounds, so that 4 <= noKeys <= 10
noKeys = max(4, min(10, noKeys));
dialog_->textAfterED->setText( controller().params().getOptions().c_str());
}

4
src/frontends/qt2/FormCitationDialogImpl.C
View File

@ -1,5 +1,5 @@
/**
* $Id: FormCitationDialogImpl.C,v 1.8 2001/06/16 14:48:12 leeming Exp $
* $Id: FormCitationDialogImpl.C,v 1.9 2001/06/17 13:22:55 leeming Exp $
*/
#include <config.h>
@ -73,7 +73,7 @@ void FormCitationDialogImpl::slotBibSelected( int sel )
infoML->clear();
infoML->setText( biblio::getInfo( theMap,
form_->bibkeys[sel-1] ).c_str() );
form_->bibkeys[sel] ).c_str() );
// Highlight the selected browser_bib key in browser_cite if
// present

1
src/frontends/xforms/FormCitation.C
View File

@ -84,7 +84,6 @@ void FormCitation::build()
bc().addReadOnly(dialog_->choice_style);
bc().addReadOnly(dialog_->input_before);
bc().addReadOnly(dialog_->input_after);
}