anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-11-22 01:59:02 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix three sign-compare compiler warning

Browse Source 
Fixes three similar warnings. One of them is the following:

src/insets/InsetInfo.cpp:1583:20: error: comparison of integers of different signs: 'int' and 'std::basic_string<wchar_t>::size_type' (aka 'unsigned long') [-Werror,-Wsign-compare]
        for (int i = 0; i < sequence.length(); ++i) {
                        ~ ^ ~~~~~~~~~~~~~~~~~
This commit is contained in:
Scott Kostyshak 2023-10-10 10:07:23 -04:00
parent 531a37baee
commit 1273f25c76
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/insets/InsetInfo.cpp
View File

@ -1580,7 +1580,7 @@ void xhtmlShortcutInfo(XMLStream & xs, const InsetInfoParams & params) {
odocstringstream ods;
string const lcode = params.lang->code();
docstring trans;
for (int i = 0; i < sequence.length(); ++i) {
for (size_t i = 0; i < sequence.length(); ++i) {
char_type const c = sequence[i];
const auto keyMapping = keyToString.find(c);
if (keyMapping != keyToString.end()) {
@ -1675,7 +1675,7 @@ void docbookMenuInfo(XMLStream & xs, Buffer const & buffer, const InsetInfoParam
xml::openTag(xs, "menuchoice", attr, "inline"); // More of an inline tag in this case, as there is no db:shortcut to
// accompany the succession of menus.
for (int i = 0; i < names.size(); ++i) {
for (size_t i = 0; i < names.size(); ++i) {
docstring const & name = names[i];
std::string tag;
@ -1746,7 +1746,7 @@ void xhtmlMenuInfo(XMLStream & xs, Buffer const & buffer, const InsetInfoParams
// Use bdo instead of span to specify the text direction (dir is only allowed globally or on bdo).
xml::openTag(xs, "bdo", attr, "inline");
for (int i = 0; i < names.size(); ++i) {
for (size_t i = 0; i < names.size(); ++i) {
docstring const & name = names[i];
//FIXME: add proper underlines here. This