anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-11-06 00:10:59 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Move the explanation of "why" into the source code and leave just "what"

Browse Source 
in the ChangeLog.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@5418 a592a061-630c-0410-9148-cb99ea01b6c8
This commit is contained in:
Angus Leeming 2002-10-15 17:24:08 +00:00
parent f4af5ce9cf
commit 131f3f1844
2 changed files with 21 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/frontends/xforms/ChangeLog
View File

@ -1,11 +1,7 @@
2002-10-15 Angus Leeming <leeming@lyx.org> 2002-10-15 Angus Leeming <leeming@lyx.org>
* XWorkArea.C (work_area_handler): it transpires that * XWorkArea.C (work_area_handler): Pass the mouse button correctly to
ev->xbutton.button == 0 when the mouse is dragged, dispatch on LFUN_MOUSE_MOTION.
so it cannot be used to initialise x_button_state and
hence FuncRequest.
This patch uses the 'key' that is passed into the function
by xforms to extract this info and so resolve the problem.
2002-10-15 Angus Leeming <leeming@lyx.org> 2002-10-15 Angus Leeming <leeming@lyx.org>

24
src/frontends/xforms/XWorkArea.C
View File

@ -368,11 +368,25 @@ int XWorkArea::work_area_handler(FL_OBJECT * ob, int event,
y_old = ev->xmotion.y; y_old = ev->xmotion.y;
scrollbar_value_old = fl_get_scrollbar_value(area->scrollbar); scrollbar_value_old = fl_get_scrollbar_value(area->scrollbar);
lyxerr[Debug::WORKAREA] << "Workarea event: MOUSE" << endl; lyxerr[Debug::WORKAREA] << "Workarea event: MOUSE" << endl;
area->dispatch(
FuncRequest(LFUN_MOUSE_MOTION, // It transpires that ev->xbutton.button == 0 when
ev->xbutton.x - ob->x, // the mouse is dragged, so it cannot be used to
ev->xbutton.y - ob->y, // initialise x_button_state and hence FuncRequest.
x_button_state(key)));
// The 'key' that is passed into the function does
// contain the necessary info, however.
// It is for this reason that x_button_state has
// been modified to work with key
// rather than ev->xbutton.button.
// Angus 15 Oct 2002.
FuncRequest cmd(LFUN_MOUSE_MOTION,
ev->xbutton.x - ob->x,
ev->xbutton.y - ob->y,
x_button_state(key));
area->dispatch(cmd);
} }
break; break;
#if FL_VERSION < 1 && FL_REVISION < 89 #if FL_VERSION < 1 && FL_REVISION < 89