anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-11-09 18:31:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Small clean-up.

Browse Source 
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@3769 a592a061-630c-0410-9148-cb99ea01b6c8
This commit is contained in:
Angus Leeming 2002-03-18 17:37:08 +00:00
parent 741f527784
commit 13978291c4
2 changed files with 32 additions and 43 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/insets/ChangeLog
View File

@ -1,3 +1,8 @@
2002-03-18 Angus Leeming <a.leeming@ic.ac.uk>
* insetgraphics.C: Clean up Baruch's comments a little.
(c-tor): remove code setting id_, as it's set in the Inset c-tor.
2002-03-18 Juergen Vigna <jug@sad.it> 2002-03-18 Juergen Vigna <jug@sad.it>
* insettabular.C (unlockInsetInInset): removed unneeded showCursor * insettabular.C (unlockInsetInInset): removed unneeded showCursor

70
src/insets/insetgraphics.C
View File

@ -13,52 +13,38 @@
Known BUGS: Known BUGS:
* If the image is from the clipart, and the document is moved to another * If the image is from the clipart, and the document is moved to another
directory, the user is screwed. Need a way to handle it. directory, the user is screwed. Need a way to handle it.
This amounts to a problem of when to use relative or absolute file paths This amounts to a problem of when to use relative or absolute file paths
We should probably use what the user asks to use... but when he chooses We should probably use what the user asks to use... but when he chooses
by the file dialog we normally get an absolute path and this may not be by the file dialog we normally get an absolute path and this may not be
what the user meant. what the user meant.
[Note that browseRelFile in helper_funcs.* provides a file name
which is relative if it is at reference path (here puffer path) Note that browseRelFile in helper_funcs.* provides a file name
level or below, and an absolute path if the file name is not a which is relative if it is at reference path (here puffer path)
`natural' relative file name. In any case, level or below, and an absolute path if the file name is not a
MakeAbsPath(filename, buf->filePath()) `natural' relative file name. In any case,
is guaranteed to provide the correct absolute path. This is what is MakeAbsPath(filename, buf->filePath())
done know for include insets. Feel free to ask me -- JMarc is guaranteed to provide the correct absolute path. This is what is
14/01/2002] done know for include insets. Feel free to ask me -- JMarc
14/01/2002
* If we are trying to create a file in a read-only directory and there
are graphics that need converting, the converting will fail because
it is done in-place, into the same directory as the original image.
This needs to be fixed in the src/converter.C file
[ This is presumed to be fixed, needs testing.]
* We do not dither or resize the image in a WYSIWYM way, we load it at
its original size and color, resizing is done in the final output,
but not in the LyX window.
TODO Before initial production release: TODO Before initial production release:
* Replace insetfig everywhere
* Search for comments of the form * What advanced features the users want to do?
// INSET_GRAPHICS: remove this when InsetFig is thrown. Implement them in a non latex dependent way, but a logical way.
And act upon them. Make sure not to remove InsetFig code for the LyX should translate it to latex or any other fitting format.
1.2.0 release, only afterwards, after deployment shows InsetGraphics
to be ok.
* What advanced features the users want to do?
Implement them in a non latex dependent way, but a logical way.
LyX should translate it to latex or any other fitting format.
* Add a way to roll the image file into the file format. * Add a way to roll the image file into the file format.
* When loading, if the image is not found in the expected place, try * When loading, if the image is not found in the expected place, try
to find it in the clipart, or in the same directory with the image. to find it in the clipart, or in the same directory with the image.
* Keep a tab on the image file, if it changes, update the lyx view. * Keep a tab on the image file, if it changes, update the lyx view.
* The image choosing dialog could show thumbnails of the image formats * The image choosing dialog could show thumbnails of the image formats
it knows of, thus selection based on the image instead of based on it knows of, thus selection based on the image instead of based on
filename. filename.
* Add support for the 'picins' package. * Add support for the 'picins' package.
* Add support for the 'picinpar' package. * Add support for the 'picinpar' package.
* Improve support for 'subfigure' - Allow to set the various options * Improve support for 'subfigure' - Allow to set the various options
that are possible. that are possible.
*/ */
/* NOTES: /* NOTES:
* Fileformat: * Fileformat:
@ -168,8 +154,6 @@ InsetGraphics::InsetGraphics(InsetGraphics const & ig, bool same_id)
cached_status_(grfx::ErrorUnknown), cache_filled_(false), old_asc(0) cached_status_(grfx::ErrorUnknown), cache_filled_(false), old_asc(0)
{ {
setParams(ig.params()); setParams(ig.params());
if (same_id)
id_ = ig.id_;
} }