fix bug 850 (fix confirmed by John)

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@6015 a592a061-630c-0410-9148-cb99ea01b6c8

src/frontends/controllers/ChangeLog

@@ -1,3 +1,10 @@
+2003-01-31  Angus Leeming  <leeming@lyx.org>
+
+	* ViewBase.h: add an isVisible() pure virtual method.
+
+	* ControlTabular.C (updateInset): don't build the dialog here.
+	Instead, do nothing if the dialog is invisible.
+
 2003-01-15  Dekel Tsur  <dekelts@tau.ac.il>
 
 	* ControlSpellchecker.[Ch]: Remove XForms RTL hacks.

src/frontends/controllers/ControlTabular.C

@@ -44,15 +44,10 @@ void ControlTabular::showInset(InsetTabular * inset)
 
 void ControlTabular::updateInset(InsetTabular * inset)
 {
+	if (!view().isVisible())
+		return;
 	lyx::Assert(inset);
-
 	connectInset(inset);
-
-	if (!dialog_built_) {
-		view().build();
-		dialog_built_ = true;
-	}
-
 	update();
 }
 

src/frontends/controllers/ViewBase.h

@@ -38,6 +38,8 @@ public:
 	virtual void show() = 0;
 	/// Update dialog before/whilst showing it.
 	virtual void update() = 0;
+	///
+	virtual bool isVisible() const = 0;
 
 	/** Defaults to nothing. Can be used by the controller, however, to
 	 *  indicate to the view that something has changed and that the

src/frontends/qt2/ChangeLog

@@ -1,3 +1,7 @@
+2003-01-31  Angus Leeming  <leeming@lyx.org>
+
+	* Qt2Base.[Ch]: instantiate the isVisible() virtual method.
+
 2003-01-30  Angus Leeming  <leeming@lyx.org>
 
 	* Dialogs2.C (createIndex): enable ControlCommand to create an

src/frontends/qt2/Qt2Base.C

@@ -38,6 +38,12 @@ Qt2BC & Qt2Base::bc()
 }
 
 
+bool Qt2Base::isVisible() const
+{
+	return form() && form()->isVisible();
+}
+
+
 void Qt2Base::show()
 {
 	if (!form()) {

src/frontends/qt2/Qt2Base.h

@@ -44,6 +44,8 @@ protected:
 	virtual void show();
 	/// update the dialog's contents
 	virtual void update_contents() = 0;
+	///
+	virtual bool isVisible() const;
 
 	/// the dialog has changed contents
 	virtual void changed();
@@ -72,7 +74,7 @@ protected slots:
 	// Close button clicked
 	void slotClose();
 private:
-	/// Pointer to the actual instantiation of xform's form
+	/// Pointer to the actual instantiation of the Qt dialog
 	virtual QDialog * form() const = 0;
 
 private:

src/frontends/xforms/ChangeLog

@@ -1,3 +1,7 @@
+2003-01-31  Angus Leeming  <leeming@lyx.org>
+
+	* FormBase.[Ch]: instantiate the isVisible() virtual method.
+
 2003-01-30  Angus Leeming  <leeming@lyx.org>
 
 	* Dialogs2.C (createIndex): enable ControlCommand to create an

src/frontends/xforms/FormBase.C

@@ -65,6 +65,12 @@ FormBase::~FormBase()
 }
 
 
+bool FormBase::isVisible() const
+{
+	return form() && form()->visible;
+}
+
+
 Tooltips & FormBase::tooltips()
 {
 	return *tooltips_;

src/frontends/xforms/FormBase.h

@@ -66,6 +66,8 @@ protected:
 	virtual void hide();
 	/// Create the dialog if necessary, update it and display it.
 	virtual void show();
+	///
+	virtual bool isVisible() const;
 
 	/** Prepare the way to:
 	 *  1. display feedback as the mouse moves over ob. This feedback will