mirror of
https://git.lyx.org/repos/lyx.git
synced 2024-12-22 05:16:21 +00:00
Fix comment.
By the way, this is extremely inefficient. We have e.g. this code in Buffer.cpp: string target = func.getArg(0); string target_name = func.getArg(1); string command = func.getArg(2); As a result, we parse the argument string three times! It seems to me that we should either (a) expose a "getArgs" routine that returns a vector<string> and let the caller extract them by position: vector<string> args = func.getArgs(); string target = args[0]; etc; or (b) cache the vector<string> in the FuncRequest object itself. The latter wouldn't in fact require much memory, because these objects are generally short-lived. Opinions? git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@32771 a592a061-630c-0410-9148-cb99ea01b6c8
This commit is contained in:
parent
1ba5857f26
commit
1d2cf2771a
@ -79,7 +79,7 @@ namespace {
|
||||
|
||||
// Extracts arguments from str into args. Arguments are delimted by
|
||||
// whitespace or by double quotes.
|
||||
// We extract at most max arguments, treating the last argument as
|
||||
// We extract at most max + 1 arguments, treating args[max] as
|
||||
// continuing to eol.
|
||||
void splitArg(vector<string> & args, string const & str,
|
||||
unsigned int max = UINT_MAX)
|
||||
|
Loading…
Reference in New Issue
Block a user