anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-11-22 01:59:02 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Modify string list in place instead of copying it

Browse Source 
Spotted by Coverity scan.
This commit is contained in:
Jean-Marc Lasgouttes 2024-09-29 21:45:08 +02:00
parent a086804eb4
commit 1d64dbf543
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/frontends/qt/GuiBibtex.cpp
View File

@ -317,14 +317,10 @@ void GuiBibtex::relAbsPressed()
QString const new_item = (p == LP_Absolute) QString const new_item = (p == LP_Absolute)
? toqstr(file.relPath(buffer().filePath())) ? toqstr(file.relPath(buffer().filePath()))
: toqstr(file.absoluteFilePath()); : toqstr(file.absoluteFilePath());
QStringList sb; for (QString & s : selected_bibs_) {
for (QString s : selected_bibs_) {
if (s == qf) if (s == qf)
sb << new_item; s = new_item;
else
sb << s;
} }
selected_bibs_ = sb;
setSelectedBibs(selected_bibs_); setSelectedBibs(selected_bibs_);
selectedLV->selectRow(selected_bibs_.indexOf(new_item)); selectedLV->selectRow(selected_bibs_.indexOf(new_item));
changed(); changed();