From 2104d41f71ff39f5c3f9f5a485707633b1bfb25b Mon Sep 17 00:00:00 2001 From: Richard Heck Date: Sun, 10 Jul 2016 01:43:19 -0400 Subject: [PATCH] Simplify logic a bit. (This was meant to be part of a previous commit.) --- src/Buffer.cpp | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/Buffer.cpp b/src/Buffer.cpp index bcefe52513..888fb93d9b 100644 --- a/src/Buffer.cpp +++ b/src/Buffer.cpp @@ -4322,12 +4322,11 @@ Buffer::ExportStatus Buffer::preview(string const & format, bool includeall) con if (status != ExportSuccess) return status; - if (previewFile.exists()) { - if (!formats.view(*this, previewFile, format)) - return PreviewError; - else - return PreviewSuccess; - } + + if (previewFile.exists()) + return formats.view(*this, previewFile, format) ? + PreviewSuccess : PreviewError; + // Successful export but no output file? // Probably a bug in error detection. LATTEST(status != ExportSuccess);