anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-12-23 05:25:26 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

utilize the 3rd arg of the boost smart pointers, remove own adaptation of boost smart ptrs.

Browse Source 
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@5046 a592a061-630c-0410-9148-cb99ea01b6c8
This commit is contained in:
Lars Gullik Bjønnes 2002-08-20 20:43:10 +00:00
parent 5e7275dabc
commit 26efdc41b3
10 changed files with 55 additions and 340 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/frontends/xforms/ChangeLog
View File

@ -1,7 +1,17 @@
2002-08-20 Lars Gullik Bjønnes <larsbj@birdstep.com>
* FormMathsBitmap.h: include boost/shared_ptr.hpp, remove include
for support/smart_ptr.h, change use of smart ptr to boost version
* FormMathsBitmap.C (FormMathsBitmap): do not initialize form_ (it
is a smart_ptr)
(build): use nifty 3rd arg of smart_ptr
(addBitmap): ditto
2002-08-20 John Levon <levon@movementarian.org>
* lyx_gui.C: estimate default DPI
2002-08-16 Angus Leeming <leeming@lyx.org>
* Dialogs.C:
@ -105,7 +115,7 @@
2002-08-13 Jean-Marc Lasgouttes <lasgouttes@freesurf.fr>
* Menubar_pimpl.C (create_submenu): fix code to disable submenu
entries.
entries.
2002-08-12 Lars Gullik Bjønnes <larsbj@gullik.net>

6
src/frontends/xforms/FormMathsBitmap.C
View File

@ -38,7 +38,7 @@ FormMathsBitmap::FormMathsBitmap(LyXView & lv, Dialogs & d,
FormMathsPanel const & p, string const & t,
vector<string> const & l)
: FormMathsSub(lv, d, p, t, false),
latex_(l), form_(0), ww_(0), x_(0), y_(0), w_(0), h_(0)
latex_(l), ww_(0), x_(0), y_(0), w_(0), h_(0)
{
ww_ = 2 * FL_abs(FL_BOUND_WIDTH);
x_ = y_ = ww_;
@ -68,7 +68,7 @@ void FormMathsBitmap::build()
h_+= 50; // Allow room for a Close button
form_.reset(fl_bgn_form(FL_UP_BOX, w_, h_));
form_.reset(fl_bgn_form(FL_UP_BOX, w_, h_), fl_free_form);
form_->u_vdata = this;
fl_add_box(FL_UP_BOX, 0, 0, w_, h_, "");
@ -135,7 +135,7 @@ void FormMathsBitmap::addBitmap(int nt, int nx, int ny, int bw, int bh,
h_ = max(y_ + wy + ww_, h_);
}
bitmaps_.push_back(bm_ptr(obj));
bitmaps_.push_back(bm_ptr(obj, fl_free_object));
}

7
src/frontends/xforms/FormMathsBitmap.h
View File

@ -15,8 +15,9 @@
#include "LString.h"
#include "FormMathsPanel.h"
#include <boost/shared_ptr.hpp>
#include <vector>
#include "support/smart_ptr.h"
#ifdef __GNUG__
#pragma interface
@ -31,9 +32,9 @@ class FormMathsBitmap : public FormMathsSub {
public:
///
typedef lyx::shared_c_ptr<FL_OBJECT> bm_ptr;
typedef boost::shared_ptr<FL_OBJECT> bm_ptr;
///
typedef lyx::shared_c_ptr<FL_FORM> fl_ptr;
typedef boost::shared_ptr<FL_FORM> fl_ptr;
///
FormMathsBitmap(LyXView &, Dialogs & d, FormMathsPanel const &,

11
src/graphics/ChangeLog
View File

@ -1,3 +1,14 @@
2002-08-20 Lars Gullik Bjønnes <larsbj@birdstep.com>
* GraphicsImageXPM.h: inlcude boost/shared_ptr.hpp, remove include
for support/smart_ptr.h, switch to boost smart ptr.
* GraphicsImageXPM.C: reorder includes, include boost/bind.hpp
(~Data): let the smart_ptr handle cleanup
(reset): use nifty 3rd arg
(resetData): ditto
(free_color_table): free the table manually
2002-08-09 Angus Leeming <leeming@lyx.org>
* PreviewLoader.C (dumpPreamble): pass Buffer::filePath() to

24
src/graphics/GraphicsImageXPM.C
View File

@ -20,14 +20,16 @@
#include "support/filetools.h" // IsFileReadable
#include "support/lstrings.h"
#include "Lsstream.h"
#include <boost/tuple/tuple.hpp>
#include <boost/bind.hpp>
#include FORMS_H_LOCATION
#include <iomanip> // std::setfill, etc
#include <cmath> // cos, sin
#include <cstdlib> // malloc, free
#include <boost/tuple/tuple.hpp>
#include FORMS_H_LOCATION
#ifndef CXX_GLOBAL_CSTD
using std::cos;
using std::sin;
@ -433,8 +435,6 @@ ImageXPM::Data::Data()
ImageXPM::Data::~Data()
{
if (colorTable_.unique())
free_color_table(colorTable_.get(), ncolors_);
}
@ -445,7 +445,7 @@ void ImageXPM::Data::reset(XpmImage & image)
cpp_ = image.cpp;
// Move the data ptr into this store and free up image.data
data_.reset(image.data);
data_.reset(image.data, free);
image.data = 0;
// Don't just store the color table, but check first that it contains
@ -478,13 +478,14 @@ void ImageXPM::Data::reset(XpmImage & image)
color.c_color = clone_c_string("none");
free_color_table(image.colorTable, image.ncolors);
colorTable_.reset(table);
colorTable_.reset(table, boost::bind(free_color_table, _1, ncolors_));
} else {
// Just move the pointer across
ncolors_ = image.ncolors;
colorTable_.reset(image.colorTable);
colorTable_.reset(image.colorTable,
boost::bind(free_color_table, _1, ncolors_));
image.colorTable = 0;
}
@ -535,7 +536,7 @@ void ImageXPM::Data::resetData(int w, int h, unsigned int * d)
{
width_ = w;
height_ = h;
data_.reset(d);
data_.reset(d, free);
}
@ -685,8 +686,7 @@ void free_color_table(XpmColor * table, size_t size)
free(table[i].g4_color);
free(table[i].c_color);
}
// Don't free the table itself. Let the shared_c_ptr do that.
// free(table);
free(table);
}

7
src/graphics/GraphicsImageXPM.h
View File

@ -16,7 +16,8 @@
#include "GraphicsImage.h"
#include XPM_H_LOCATION
#include "support/smart_ptr.h"
#include <boost/shared_ptr.hpp>
#ifdef __GNUG__
#pragma interface
@ -129,8 +130,8 @@ private:
unsigned int height_;
unsigned int cpp_;
unsigned int ncolors_;
lyx::shared_c_ptr<unsigned int> data_;
lyx::shared_c_ptr<XpmColor> colorTable_;
boost::shared_ptr<unsigned int> data_;
boost::shared_ptr<XpmColor> colorTable_;
unsigned int color_none_id() const;
};

8
src/support/ChangeLog
View File

@ -1,3 +1,11 @@
2002-08-20 Lars Gullik Bjønnes <larsbj@birdstep.com>
* Makefile.am (libsupport_la_SOURCES): delete smart_ptr.h and
utility.h
* smart_ptr.h: remove file
* utility.h: ditto
2002-08-20 Lars Gullik Bjønnes <larsbj@gullik.net>
* lyxfunctional.h: remove class_fun_t, void_class_fun_t,

4
src/support/Makefile.am
View File

@ -53,7 +53,6 @@ libsupport_la_SOURCES = \
putenv.C \
rename.C \
rmdir.C \
smart_ptr.h \
snprintf.h \
snprintf.c \
sstream.h \
@ -63,5 +62,4 @@ libsupport_la_SOURCES = \
textutils.h \
translator.h \
types.h \
unlink.C \
utility.h
unlink.C

261
src/support/smart_ptr.h
View File

@ -1,261 +0,0 @@
// Baruch Even baruch@ev-en.org 2001-02-20
// This version is a modified version for use in LyX
// The modifications are done in order to use it where exceptions are disabled
// Currently it has no "no memory" checks in place, asserts are probably the
// only real way.
// all changed are #ifded'ed by LYX_NO_EXCEPTIONS
#define LYX_NO_EXCEPTIONS
// Boost smart_ptr.hpp header file -----------------------------------------//
// (C) Copyright Greg Colvin and Beman Dawes 1998, 1999. Permission to copy,
// use, modify, sell and distribute this software is granted provided this
// copyright notice appears in all copies. This software is provided "as is"
// without express or implied warranty, and with no claim as to its
// suitability for any purpose.
// See http://www.boost.org for most recent version including documentation.
// Revision History
// 21 May 01 Require complete type where incomplete type is unsafe.
// (suggested by Vladimir Prus)
// 21 May 01 operator= fails if operand transitively owned by *this, as in a
// linked list (report by Ken Johnson, fix by Beman Dawes)
// 21 Jan 01 Suppress some useless warnings with MSVC (David Abrahams)
// 19 Oct 00 Make shared_ptr ctor from auto_ptr explicit. (Robert Vugts)
// 24 Jul 00 Change throw() to // never throws. See lib guidelines
// Exception-specification rationale. (Beman Dawes)
// 22 Jun 00 Remove #if continuations to fix GCC 2.95.2 problem (Beman Dawes)
// 1 Feb 00 Additional shared_ptr BOOST_NO_MEMBER_TEMPLATES workarounds
// (Dave Abrahams)
// 31 Dec 99 Condition tightened for no member template friend workaround
// (Dave Abrahams)
// 30 Dec 99 Moved BOOST_NMEMBER_TEMPLATES compatibility code to config.hpp
// (Dave Abrahams)
// 30 Nov 99 added operator ==, operator !=, and std::swap and std::less
// specializations for shared types (Darin Adler)
// 11 Oct 99 replaced op[](int) with op[](std::size_t) (Ed Brey, Valentin
// Bonnard), added shared_ptr workaround for no member template
// friends (Matthew Langston)
// 25 Sep 99 added shared_ptr::swap and shared_array::swap (Luis Coelho).
// 20 Jul 99 changed name to smart_ptr.hpp, #include <boost/config.hpp>,
// #include <boost/utility.hpp> and use boost::noncopyable
// 17 May 99 remove scoped_array and shared_array operator*() as
// unnecessary (Beman Dawes)
// 14 May 99 reorder code so no effects when bad_alloc thrown (Abrahams/Dawes)
// 13 May 99 remove certain throw() specifiers to avoid generated try/catch
// code cost (Beman Dawes)
// 11 May 99 get() added, conversion to T* placed in macro guard (Valentin
// Bonnard, Dave Abrahams, and others argued for elimination
// of the automatic conversion)
// 28 Apr 99 #include <memory> fix (Valentin Bonnard)
// 28 Apr 99 rename transfer() to share() for clarity (Dave Abrahams)
// 28 Apr 99 remove unsafe shared_array template conversions(Valentin Bonnard)
// 28 Apr 99 p(r) changed to p(r.px) for clarity (Dave Abrahams)
// 21 Apr 99 reset() self assignment fix (Valentin Bonnard)
// 21 Apr 99 dispose() provided to improve clarity (Valentin Bonnard)
// 27 Apr 99 leak when new throws fixes (Dave Abrahams)
// 21 Oct 98 initial Version (Greg Colvin/Beman Dawes)
#ifndef LYX_SMART_PTR_H
#define LYX_SMART_PTR_H
#include <boost/config.hpp> // for broken compiler workarounds
#include <cstddef> // for std::size_t
#include <memory> // for std::auto_ptr
#include <algorithm> // for std::swap
#include "support/utility.h" // for boost::noncopyable, checked_delete, checked_array_delete
#include <functional> // for std::less
#include <boost/static_assert.hpp> // for BOOST_STATIC_ASSERT
#ifdef LYX_NO_EXCEPTIONS
#include <assert.h>
#endif
namespace lyx {
// shared_ptr --------------------------------------------------------------//
// An enhanced relative of scoped_ptr with reference counted copy semantics.
// The object pointed to is deleted when the last shared_ptr pointing to it
// is destroyed or reset.
template<typename T> class shared_c_ptr {
public:
typedef T element_type;
explicit shared_c_ptr(T* p =0) : px(p) {
#ifndef LYX_NO_EXCEPTIONS
try { pn = new long(1); } // fix: prevent leak if new throws
catch (...) { checked_delete(p); throw; }
#else
pn = new long(1);
assert(pn != 0);
#endif
}
shared_c_ptr(const shared_c_ptr& r) : px(r.px) { ++*(pn = r.pn); } // never throws
~shared_c_ptr() { dispose(); }
shared_c_ptr& operator=(const shared_c_ptr& r) {
share(r.px,r.pn);
return *this;
}
#if !defined(BOOST_NO_MEMBER_TEMPLATES)
template<typename Y>
shared_c_ptr(const shared_c_ptr<Y>& r) : px(r.px) { // never throws
++*(pn = r.pn);
}
#ifndef BOOST_NO_AUTO_PTR
template<typename Y>
explicit shared_c_ptr(std::auto_ptr<Y>& r) {
pn = new long(1); // may throw
px = r.release(); // fix: moved here to stop leak if new throws
}
#endif
template<typename Y>
shared_c_ptr& operator=(const shared_c_ptr<Y>& r) {
share(r.px,r.pn);
return *this;
}
#ifndef BOOST_NO_AUTO_PTR
template<typename Y>
shared_c_ptr& operator=(std::auto_ptr<Y>& r) {
// code choice driven by guarantee of "no effect if new throws"
if (*pn == 1) { checked_delete(px); }
else { // allocate new reference counter
long * tmp = new long(1); // may throw
--*pn; // only decrement once danger of new throwing is past
pn = tmp;
} // allocate new reference counter
px = r.release(); // fix: moved here so doesn't leak if new throws
return *this;
}
#endif
#else
#ifndef BOOST_NO_AUTO_PTR
explicit shared_c_ptr(std::auto_ptr<T>& r) {
pn = new long(1); // may throw
px = r.release(); // fix: moved here to stop leak if new throws
}
shared_c_ptr& operator=(std::auto_ptr<T>& r) {
// code choice driven by guarantee of "no effect if new throws"
if (*pn == 1) { checked_delete(px); }
else { // allocate new reference counter
long * tmp = new long(1); // may throw
--*pn; // only decrement once danger of new throwing is past
pn = tmp;
} // allocate new reference counter
px = r.release(); // fix: moved here so doesn't leak if new throws
return *this;
}
#endif
#endif
void reset(T* p=0) {
if (px == p) return; // fix: self-assignment safe
if (--*pn == 0) { checked_delete(px); }
else { // allocate new reference counter
#ifndef LYX_NO_EXCEPTIONS
try { pn = new long; } // fix: prevent leak if new throws
catch (...) {
++*pn; // undo effect of --*pn above to meet effects guarantee
checked_delete(p);
throw;
} // catch
#else
pn = new long;
assert(pn != 0);
#endif
} // allocate new reference counter
*pn = 1;
px = p;
} // reset
T& operator*() const { return *px; } // never throws
T* operator->() const { return px; } // never throws
T* get() const { return px; } // never throws
long use_count() const { return *pn; } // never throws
bool unique() const { return *pn == 1; } // never throws
void swap(shared_c_ptr<T>& other) // never throws
{ std::swap(px,other.px); std::swap(pn,other.pn); }
// Tasteless as this may seem, making all members public allows member templates
// to work in the absence of member template friends. (Matthew Langston)
// Don't split this line into two; that causes problems for some GCC 2.95.2 builds
#if defined(BOOST_NO_MEMBER_TEMPLATES) || !defined(BOOST_NO_MEMBER_TEMPLATE_FRIENDS)
private:
#endif
T* px; // contained pointer
long* pn; // ptr to reference counter
// Don't split this line into two; that causes problems for some GCC 2.95.2 builds
#if !defined( BOOST_NO_MEMBER_TEMPLATES ) && !defined( BOOST_NO_MEMBER_TEMPLATE_FRIENDS )
template<typename Y> friend class shared_ptr;
#endif
void dispose() { if (--*pn == 0) { checked_delete(px); delete pn; } }
void share(T* rpx, long* rpn) {
if (pn != rpn) { // Q: why not px != rpx? A: fails when both == 0
++*rpn; // done before dispose() in case rpn transitively
// dependent on *this (bug reported by Ken Johnson)
dispose();
px = rpx;
pn = rpn;
}
} // share
}; // shared_ptr
template<typename T, typename U>
inline bool operator==(const shared_c_ptr<T>& a, const shared_c_ptr<U>& b)
{ return a.get() == b.get(); }
template<typename T, typename U>
inline bool operator!=(const shared_c_ptr<T>& a, const shared_c_ptr<U>& b)
{ return a.get() != b.get(); }
} // namespace boost
// specializations for things in namespace std -----------------------------//
#ifndef BOOST_NO_TEMPLATE_PARTIAL_SPECIALIZATION
namespace std {
// Specialize std::swap to use the fast, non-throwing swap that's provided
// as a member function instead of using the default algorithm which creates
// a temporary and uses assignment.
template<typename T>
inline void swap(lyx::shared_c_ptr<T>& a, lyx::shared_c_ptr<T>& b)
{ a.swap(b); }
// Specialize std::less so we can use shared pointers and arrays as keys in
// associative collections.
// It's still a controversial question whether this is better than supplying
// a full range of comparison operators (<, >, <=, >=).
template<typename T>
struct less< lyx::shared_c_ptr<T> >
: binary_function<lyx::shared_c_ptr<T>, lyx::shared_c_ptr<T>, bool>
{
bool operator()(const lyx::shared_c_ptr<T>& a,
const lyx::shared_c_ptr<T>& b) const
{ return less<T*>()(a.get(),b.get()); }
};
} // namespace std
#endif // ifndef BOOST_NO_TEMPLATE_PARTIAL_SPECIALIZATION
#endif // LYX_SMART_PTR_H

53
src/support/utility.h
View File

@ -1,53 +0,0 @@
// boost utility.hpp header file -------------------------------------------//
// (C) Copyright boost.org 1999. Permission to copy, use, modify, sell
// and distribute this software is granted provided this copyright
// notice appears in all copies. This software is provided "as is" without
// express or implied warranty, and with no claim as to its suitability for
// any purpose.
// See http://www.boost.org for most recent version including documentation.
// Classes appear in alphabetical order
// Revision History
// 21 May 01 checked_delete() and checked_array_delete() added (Beman Dawes,
// suggested by Dave Abrahams, generalizing idea from Vladimir Prus)
// 21 May 01 made next() and prior() inline (Beman Dawes)
// 26 Jan 00 protected noncopyable destructor added (Miki Jovanovic)
// 10 Dec 99 next() and prior() templates added (Dave Abrahams)
// 30 Aug 99 moved cast templates to cast.hpp (Beman Dawes)
// 3 Aug 99 cast templates added
// 20 Jul 99 name changed to utility.hpp
// 9 Jun 99 protected noncopyable default ctor
// 2 Jun 99 Initial Version. Class noncopyable only contents (Dave Abrahams)
#ifndef LYX_UTILITY_H
#define LYX_UTILITY_H
#include <boost/config.hpp> // broken compiler workarounds
#include <boost/static_assert.hpp>
//#include <cstddef> // for size_t
//#include <utility> // for std::pair
#ifndef CXX_GLOBAL_CSTD
using std::free;
#endif
namespace lyx
{
// checked_delete() and checked_array_delete() -----------------------------//
// verify that types are complete for increased safety
template< typename T >
inline void checked_delete(T * x)
{
BOOST_STATIC_ASSERT( sizeof(T) != 0 ); // assert type complete at point
// of instantiation
::free(x);
}
} // namespace boost
#endif // BOOST_UTILITY_HPP