Make sure we have a buffer in VC_COMPARE.

Fixes coverity #23304.
This commit is contained in:
Richard Heck 2016-06-11 22:41:57 -04:00
parent edefef17b5
commit 2cb6ed9376

View File

@ -3241,7 +3241,6 @@ void GuiView::dispatchVC(FuncRequest const & cmd, DispatchResult & dr)
} }
case LFUN_VC_COMPARE: { case LFUN_VC_COMPARE: {
if (cmd.argument().empty()) { if (cmd.argument().empty()) {
lyx::dispatch(FuncRequest(LFUN_DIALOG_SHOW, "comparehistory")); lyx::dispatch(FuncRequest(LFUN_DIALOG_SHOW, "comparehistory"));
break; break;
@ -3251,6 +3250,8 @@ void GuiView::dispatchVC(FuncRequest const & cmd, DispatchResult & dr)
string f1, f2; string f1, f2;
// f1 // f1
// it seems safe to assume we have a buffer
// coverity[FORWARD_NULL]
if (!buffer->lyxvc().prepareFileRevision(rev1, f1)) if (!buffer->lyxvc().prepareFileRevision(rev1, f1))
break; break;