Do not crash is release mode if we stumble across an unrealized font.

(cherry picked from commit 3203fb1c5f)

src/frontends/qt4/GuiFontLoader.cpp

@@ -95,11 +95,24 @@ static GuiFontInfo * fontinfo_[NUM_FAMILIES][NUM_SERIES][NUM_SHAPE][NUM_SIZE];
 // if not cached, create it.
 GuiFontInfo & fontinfo(FontInfo const & f)
 {
-	// LASSERT: Is there anything we might do here besides crash?
-	LBUFERR(f.family() < NUM_FAMILIES);
-	LBUFERR(f.series() < NUM_SERIES);
-	LBUFERR(f.realShape() < NUM_SHAPE);
-	LBUFERR(f.size() < NUM_SIZE);
+    bool const fontIsRealized =
+            (f.family() < NUM_FAMILIES) &&
+            (f.series() < NUM_SERIES) &&
+            (f.realShape() < NUM_SHAPE) &&
+            (f.size() < NUM_SIZE);
+    if (!fontIsRealized) {
+        // We can reset the font to something sensible in release mode.
+        LATTEST(false);
+        LYXERR0("Unrealized font!");
+        // We could be fancier here, if we wanted, and just fix things where
+        // there is a problem. But it doesn't seem worth it, since we should
+        // not be here in the first place.
+        GuiFontInfo * & fi =
+            fontinfo_[sane_font.family()][sane_font.series()][sane_font.realShape()][sane_font.size()];
+        if (!fi)
+            fi = new GuiFontInfo(f);
+        return *fi;
+    }
 	// fi is a reference to the pointer type (GuiFontInfo *) in the
 	// fontinfo_ table.
 	GuiFontInfo * & fi =

status.22x

@@ -40,6 +40,8 @@ What's new
 
 * USER INTERFACE
 
+- Avoid crashing in release mode if we stumble across an unrealized font.
+
 - Fix display of citations with two authors. 
 
 - Fix display of multi-author citations when the GUI language is not English.