Don't need this argument, since it was only ever called thus:

it->fillWithBibKeys(d->bibinfo_, it);
This could be useful later, if we decide to try to do the work that
fillWithBibKeys did from updateLabels().


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35106 a592a061-630c-0410-9148-cb99ea01b6c8
This commit is contained in:
Richard Heck 2010-08-09 18:00:46 +00:00
parent 506716a1d2
commit 35f3f7cbc4
8 changed files with 18 additions and 12 deletions

View File

@ -1801,7 +1801,7 @@ void Buffer::checkBibInfoCache() const
if (!d->bibinfo_cache_valid_) {
d->bibinfo_.clear();
for (InsetIterator it = inset_iterator_begin(inset()); it; ++it)
it->fillWithBibKeys(d->bibinfo_, it);
it->fillWithBibKeys(d->bibinfo_);
d->bibinfo_cache_valid_ = true;
}
}

View File

@ -478,7 +478,7 @@ public:
/// pit is the ParConstIterator of the paragraph containing the inset
virtual void addToToc(DocIterator const &) {}
/// Fill keys with BibTeX information
virtual void fillWithBibKeys(BiblioInfo &, InsetIterator const &) const {}
virtual void fillWithBibKeys(BiblioInfo &) const {}
/// Update the counters of this inset and of its contents.
/// The boolean indicates whether we are preparing for output, e.g.,
/// of XHTML.

View File

@ -258,11 +258,17 @@ docstring bibitemWidest(Buffer const & buffer, OutputParams const & runparams)
}
void InsetBibitem::fillWithBibKeys(BiblioInfo & keys, InsetIterator const & it) const
void InsetBibitem::fillWithBibKeys(BiblioInfo & keys) const
{
docstring const key = getParam("key");
// false means it's not BibTeX
BibTeXInfo keyvalmap(false);
keyvalmap.label(bibLabel());
// The indirection here is a little annoying, but
// DocIterator(Buffer *, Inset *)
// is private.
InsetBibitem & me = const_cast<InsetBibitem &>(*this);
InsetIterator it(me);
DocIterator doc_it(it);
doc_it.forwardPos();
keyvalmap[from_ascii("ref")] = doc_it.paragraph().asString();

View File

@ -63,7 +63,7 @@ private:
///
docstring xhtml(XHTMLStream &, OutputParams const &) const;
///
virtual void fillWithBibKeys(BiblioInfo &, InsetIterator const &) const;
virtual void fillWithBibKeys(BiblioInfo &) const;
/// Update the counter of this inset
void updateBuffer(ParIterator const &, UpdateType);
///

View File

@ -662,8 +662,7 @@ namespace {
// This method returns a comma separated list of Bibtex entries
void InsetBibtex::fillWithBibKeys(BiblioInfo & keylist,
InsetIterator const & /*di*/) const
void InsetBibtex::fillWithBibKeys(BiblioInfo & keylist) const
{
// This bibtex parser is a first step to parse bibtex files
// more precisely.

View File

@ -42,7 +42,7 @@ public:
///
int latex(odocstream &, OutputParams const &) const;
///
void fillWithBibKeys(BiblioInfo &, InsetIterator const &) const;
void fillWithBibKeys(BiblioInfo &) const;
///
support::FileNameList getBibFiles() const;
///

View File

@ -830,12 +830,13 @@ void InsetInclude::validate(LaTeXFeatures & features) const
}
void InsetInclude::fillWithBibKeys(BiblioInfo & keys,
InsetIterator const & /*di*/) const
void InsetInclude::fillWithBibKeys(BiblioInfo & keys) const
{
if (loadIfNeeded()) {
string const included_file = includedFileName(buffer(), params()).absFileName();
Buffer * tmp = theBufferList().getBuffer(FileName(included_file));
string const included_file =
includedFileName(buffer(), params()).absFileName();
Buffer * tmp =
theBufferList().getBuffer(FileName(included_file));
BiblioInfo const & newkeys = tmp->localBibInfo();
keys.mergeBiblioInfo(newkeys);
}

View File

@ -59,7 +59,7 @@ public:
* \param keys the list of bibkeys in the child buffer.
* \param it not used here
*/
void fillWithBibKeys(BiblioInfo & keys, InsetIterator const & it) const;
void fillWithBibKeys(BiblioInfo & keys) const;
///
bool hasSettings() const { return true; }