anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-09-20 06:49:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Adjust the FIXME texts and Delete commented out setXY() call following Andre comments about it:

Browse Source 
The coordcahce is for up/down navigation and vconverting mouseclicks to text positions. It is not for pure display/export which
is what drawT is about. It was a simple oversight not to remove it after some copying from the 'real' draw() method.



git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@15347 a592a061-630c-0410-9148-cb99ea01b6c8
This commit is contained in:
Abdelrazak Younes 2006-10-16 09:08:05 +00:00
parent 0823fb6f86
commit 3a32fff90e
2 changed files with 12 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/mathed/MathData.C
View File

@ -333,21 +333,8 @@ void MathArray::drawT(TextPainter & pain, int x, int y) const
{
//lyxerr << "x: " << x << " y: " << y << ' ' << pain.workAreaHeight() << endl;
// FIXME: Abdel 13/10/2006
// The setXV() call below is commented out for now because
// we don't have access to a BufferView at this level.
// In any case, this drawT() method is never used, this is dead code.
//
/* Georg explanation of current situation:
AFAIK the text painter was used to export math formulas as ASCII art.
Therefore the setXY() call makes sense. Imagine that the text painter is
like a real painter, but operating on a very coarse grid of character cells
where each cell can be filled with an ASCII character.
I don't know why it is currently disabled. I do know that we have a bugzilla
request for reenabling it. I believe only Andre can tell whether that is
doable or whether the whole drawT machinery should be removed.
*/
//setXY(bv, x, y);
// FIXME: Abdel 16/10/2006
// This drawT() method is never used, this is dead code.
for (const_iterator it = begin(), et = end(); it != et; ++it) {
(*it)->drawT(pain, x, y);

10
src/mathed/TextPainter.h
View File

@ -17,6 +17,16 @@
#include <vector>
// FIXME: Abdel 16/10/2006
// This TextPainter class is never used, this is dead code.
/* Georg explanation of current situation:
AFAIK the text painter was used to export math formulas as ASCII art.
The text painter is like a real painter, but operating on a very coarse
grid of character cells where each cell can be filled with an ASCII character.
I don't know why it is currently disabled. I do know that we have a bugzilla
request for reenabling it.
*/
class TextPainter {
public:
///