From 4521fc757ba5906402e2e46b23b47dfc7f436675 Mon Sep 17 00:00:00 2001 From: Enrico Forestieri Date: Mon, 25 Aug 2014 19:27:45 +0200 Subject: [PATCH] Replace Q_WS_WIN with appropriate guards to account for Qt5. This commit replaces almost all occurrences of Q_WS_WIN to comply with Qt5. The remaining occurrences should *not* be replaced, because the guarded code won't compile on Qt5. --- src/frontends/qt4/FileDialog.cpp | 2 +- src/frontends/qt4/GuiClipboard.cpp | 2 +- src/frontends/qt4/GuiView.cpp | 2 +- src/frontends/qt4/Menus.cpp | 4 ++-- src/frontends/qt4/qt_helpers.cpp | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/frontends/qt4/FileDialog.cpp b/src/frontends/qt4/FileDialog.cpp index 8f63d2e18a..2b60fbf951 100644 --- a/src/frontends/qt4/FileDialog.cpp +++ b/src/frontends/qt4/FileDialog.cpp @@ -35,7 +35,7 @@ * * Therefore there is a tradeoff in enabling or disabling this (JMarc) */ -#if defined(Q_WS_MACX) || (defined(Q_WS_WIN) && !defined(Q_OS_CYGWIN)) +#if defined(Q_WS_MACX) || defined(Q_OS_WIN) #define USE_NATIVE_FILEDIALOG 1 #endif diff --git a/src/frontends/qt4/GuiClipboard.cpp b/src/frontends/qt4/GuiClipboard.cpp index d96dd26f0b..7aad7a9560 100644 --- a/src/frontends/qt4/GuiClipboard.cpp +++ b/src/frontends/qt4/GuiClipboard.cpp @@ -541,7 +541,7 @@ bool GuiClipboard::hasInternal() const // are notified of changes. However, on Windows ownership is // emulated by Qt through the OleIsCurrentClipboard() API, while // on Mac OS X we deal with this issue by ourself. -#if (defined(Q_WS_X11) || defined(Q_WS_WIN)) +#if defined(Q_WS_X11) || defined(Q_OS_WIN) || defined(Q_CYGWIN_WIN) return true; #else return false; diff --git a/src/frontends/qt4/GuiView.cpp b/src/frontends/qt4/GuiView.cpp index a7cbbe49fe..08b9c35e0e 100644 --- a/src/frontends/qt4/GuiView.cpp +++ b/src/frontends/qt4/GuiView.cpp @@ -448,7 +448,7 @@ GuiView::GuiView(int id) // We don't want to keep the window in memory if it is closed. setAttribute(Qt::WA_DeleteOnClose, true); -#if (!defined(Q_WS_WIN) && !defined(Q_WS_MACX)) +#if !(defined(Q_OS_WIN) || defined(Q_CYGWIN_WIN)) && !defined(Q_WS_MACX) // QIcon::fromTheme was introduced in Qt 4.6 #if (QT_VERSION >= 0x040600) // assign an icon to main form. We do not do it under Qt/Win or Qt/Mac, diff --git a/src/frontends/qt4/Menus.cpp b/src/frontends/qt4/Menus.cpp index 5a901d8acc..ece5eed6b9 100644 --- a/src/frontends/qt4/Menus.cpp +++ b/src/frontends/qt4/Menus.cpp @@ -1774,7 +1774,7 @@ void Menu::Impl::populate(QMenu & qMenu, MenuDefinition const & menu) } } -#if defined(Q_WS_WIN) && (QT_VERSION >= 0x040600) +#if (defined(Q_OS_WIN) || defined(Q_CYGWIN_WIN)) && (QT_VERSION >= 0x040600) class AlwaysMnemonicStyle : public QProxyStyle { public: int styleHint(StyleHint hint, const QStyleOption *opt = 0, const QWidget *widget = 0, @@ -1794,7 +1794,7 @@ public: Menu::Menu(GuiView * gv, QString const & name, bool top_level, bool keyboard) : QMenu(gv), d(new Menu::Impl) { -#if defined(Q_WS_WIN) && (QT_VERSION >= 0x040600) +#if (defined(Q_OS_WIN) || defined(Q_CYGWIN_WIN)) && (QT_VERSION >= 0x040600) if (keyboard) setStyle(new AlwaysMnemonicStyle); #else diff --git a/src/frontends/qt4/qt_helpers.cpp b/src/frontends/qt4/qt_helpers.cpp index 2b62371885..dc78b9dbac 100644 --- a/src/frontends/qt4/qt_helpers.cpp +++ b/src/frontends/qt4/qt_helpers.cpp @@ -301,7 +301,7 @@ QString const externalLineEnding(docstring const & str) #ifdef Q_WS_MACX // The MAC clipboard uses \r for lineendings, and we use \n return toqstr(subst(str, '\n', '\r')); -#elif defined(Q_WS_WIN) +#elif defined(Q_OS_WIN) || defined(Q_CYGWIN_WIN) // Windows clipboard uses \r\n for lineendings, and we use \n return toqstr(subst(str, from_ascii("\n"), from_ascii("\r\n"))); #else