anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-11-07 02:28:35 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add comment regarding fsanitize + Clang issue

Browse Source 
We could not figure out the root issue, or at least not to the point
where we felt changing this code considering we could not trigger
any bug from a user perspective.

For now, we just add a comment in the code.

For more information, see our ML discussion here:

  https://www.mail-archive.com/search?l=mid&q=20211227113249.53bf5a63%40admin1-desktop
This commit is contained in:
Scott Kostyshak 2021-12-30 11:37:12 -05:00
parent 011be4a959
commit 4bdb1ca4c2
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/support/socktools.cpp
View File

@ -111,6 +111,13 @@ int listen(FileName const & name, int queue)
// bind() gives the local address 'name' for 'fd', also creating
// the socket special file in the filesystem. bind() returns -1
// in case of error
//
// Using Clang and fsanitize suggests there is an issue here but we do
// not understand the code enough to change it and we are not aware of
// how to trigger a crash or other issue while using LyX, so we leave
// it as is. For ML discussion, see here:
// https://www.mail-archive.com/search?l=mid&q=20211227113249.53bf5a63%40admin1-desktop
//
if ((::bind (fd, reinterpret_cast<sockaddr *>(&addr), SUN_LEN(&addr))) == -1) {
LYXERR0("lyx: Could not bind address '" << name.absFileName()
<< "' to socket descriptor: " << strerror(errno));