anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-09-19 22:40:26 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix bug #8342: Endless undo group messages

Browse Source 
Fix thinko in Undo::endUndoGroup.
Do not reset undo groups in Undo::clean

The underlying problem remains: the various VC functions should not
always reload the buffer or at least should use the parameter
clearUndo=false.
This commit is contained in:
Jean-Marc Lasgouttes 2012-09-17 11:24:39 +02:00
parent 51c380440b
commit 538570a1e5
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/Undo.cpp
View File

@ -249,8 +249,10 @@ void Undo::clear()
d->undostack_.clear();
d->redostack_.clear();
d->undo_finished_ = true;
d->group_id = 0;
d->group_level = 0;
// We used to do that, but I believe it is better to keep
// groups (only used in Buffer::reload for now (JMarc)
//d->group_id = 0;
//d->group_level = 0;
}
@ -511,8 +513,10 @@ void Undo::beginUndoGroup()
void Undo::endUndoGroup()
{
if (d->group_level == 0)
if (d->group_level == 0) {
LYXERR0("There is no undo group to end here");
return;
}
--d->group_level;
if (d->group_level == 0) {
// real end of the group