anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-11-26 19:25:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Do not return a reference to a temporary variable

Browse Source 
Coverity correctly spotted that the existing code creates a temporary
map and returns a value from it. It is not possible to make the map
const& directly because operator[] may change the map.

Therefore, we use map::find instead.
This commit is contained in:
Jean-Marc Lasgouttes 2017-03-01 17:35:05 +01:00
parent 1f10969bb5
commit 5453e00cfa
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/BufferParams.cpp
View File

@ -3305,8 +3305,12 @@ bool BufferParams::addCiteEngine(vector<string> const & engine)
string const & BufferParams::defaultBiblioStyle() const
{
map<string, string> bs = documentClass().defaultBiblioStyle();
return bs[theCiteEnginesList.getTypeAsString(citeEngineType())];
map<string, string> const & bs = documentClass().defaultBiblioStyle();
auto cit = bs.find(theCiteEnginesList.getTypeAsString(citeEngineType()));
if (cit != bs.end())
return cit->second;
else
return empty_string();
}