anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-11-22 18:08:10 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Pass BufferParams by address

Browse Source 
Spotted by coverity.

Note that this probably fixes a bug in getTokenValue(), where an author
was added to the BufferParams copy.
This commit is contained in:
Jean-Marc Lasgouttes 2020-06-18 11:17:32 +02:00
parent 70ccf9f243
commit 5aadf0879f
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/CutAndPaste.cpp
View File

@ -602,7 +602,7 @@ Buffer * copyToTempBuffer(ParagraphList const & paragraphs, DocumentClassConstPt
void putClipboard(ParagraphList const & paragraphs, void putClipboard(ParagraphList const & paragraphs,
DocumentClassConstPtr docclass, docstring const & plaintext, DocumentClassConstPtr docclass, docstring const & plaintext,
BufferParams const bp) BufferParams const & bp)
{ {
Buffer * buffer = copyToTempBuffer(paragraphs, docclass); Buffer * buffer = copyToTempBuffer(paragraphs, docclass);
if (!buffer) // already asserted in copyToTempBuffer() if (!buffer) // already asserted in copyToTempBuffer()

4
src/insets/InsetTabular.cpp
View File

@ -451,7 +451,7 @@ bool getTokenValue(string const & str, char const * token, Length & len)
} }
bool getTokenValue(string const & str, char const * token, Change & change, BufferParams bp) bool getTokenValue(string const & str, char const * token, Change & change, BufferParams & bp)
{ {
// set the change to be Change() as default as this it should be if not // set the change to be Change() as default as this it should be if not
// in the file format. // in the file format.
@ -574,7 +574,7 @@ string const write_attribute(string const & name, Length const & value)
return value.zero() ? string() : write_attribute(name, value.asString()); return value.zero() ? string() : write_attribute(name, value.asString());
} }
string const write_attribute(string const & name, Change const & change, BufferParams const bp) string const write_attribute(string const & name, Change const & change, BufferParams const & bp)
{ {
odocstringstream ods; odocstringstream ods;
if (change.inserted()) if (change.inserted())