From 5bd14af8871b8f87c2c73ca8392b7c72217ad72d Mon Sep 17 00:00:00 2001 From: Enrico Forestieri Date: Sat, 12 Jul 2014 19:12:08 +0200 Subject: [PATCH] Fix bug #9193: Spacing modification not exact The conversion from floating point to string performed by boost:lexical_cast does not allow specifying a precision and, for example, values such as 0.9 are resturned as 0.899999976. The standard C++ way for performing the conversion is using std::ostringstream which is exempt from this problem, even if less efficient. For the sake of accuracy, boost::lexical_cast is ditched in favor of the ostrinsgstream implementation. In C++11 another option would be using std::to_string, but I think it is not as efficient as the boost way and not worth implementing through #ifdef's. Incidentally, this patch would have also fixed #9190 and all similar cases involving the use of convert(float|double). --- src/support/convert.cpp | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/support/convert.cpp b/src/support/convert.cpp index 70cd91eeba..6b985f50ba 100644 --- a/src/support/convert.cpp +++ b/src/support/convert.cpp @@ -17,6 +17,7 @@ #include #include +#include //needed for Mac OSX 10.5.2 Leopard #include @@ -106,14 +107,18 @@ docstring convert(long l) template<> string convert(float f) { - return lexical_cast(f); + std::ostringstream val; + val << f; + return val.str(); } template<> string convert(double d) { - return lexical_cast(d); + std::ostringstream val; + val << d; + return val.str(); }