More llvm/clang warnings

This is mostly unused private class members.

There are also a few unused functions that got #if'ed out. I never know in this case whether the code should be nuked.

src/Text.cpp

@@ -582,7 +582,7 @@ class TextCompletionList : public CompletionList
 public:
 	///
 	TextCompletionList(Cursor const & cur, WordList const * list)
-		: buffer_(cur.buffer()), pos_(0), list_(list)
+		: buffer_(cur.buffer()), list_(list)
 	{}
 	///
 	virtual ~TextCompletionList() {}
@@ -604,8 +604,6 @@ private:
 	///
 	Buffer const * buffer_;
 	///
-	size_t pos_;
-	///
 	WordList const * list_;
 };
 

src/frontends/qt4/EmptyTable.h

@@ -48,11 +48,6 @@ protected:
 	virtual void resetCellSize();
 
 private:
-	/// number of current columns
-	unsigned int cols;
-	/// number of current rows
-	unsigned int rows;
-
 };
 
 

src/frontends/qt4/GuiCharacter.cpp

@@ -160,7 +160,7 @@ void fillCombo(QComboBox * combo, QList<T> const & list)
 
 GuiCharacter::GuiCharacter(GuiView & lv)
 	: GuiDialog(lv, "character", qt_("Text Style")), font_(ignore_font, ignore_language),
-	  toggleall_(false), reset_lang_(false)
+	  toggleall_(false)
 {
 	setupUi(this);
 

src/frontends/qt4/GuiCharacter.h

@@ -95,9 +95,6 @@ private:
 	Font font_;
 	///
 	bool toggleall_;
-	/// If true the language should be reset.
-	/// If false the language of font_ is used.
-	bool reset_lang_;
 };
 
 } // namespace frontend

src/frontends/qt4/GuiPrefs.h

@@ -125,7 +125,6 @@ private:
 	/// A list of colors to be dispatched
 	std::vector<std::string> colors_;
 
-	bool redraw_gui_;
 	bool update_screen_font_;
 };
 

src/frontends/qt4/GuiToolbar.cpp

@@ -272,7 +272,7 @@ void GuiToolbar::add(ToolbarItem const & item)
 		tb->setToolTip(label);
 		tb->setStatusTip(label);
 		tb->setText(label);
-		InsertTableWidget * iv = new InsertTableWidget(owner_, tb);
+		InsertTableWidget * iv = new InsertTableWidget(tb);
 		connect(tb, SIGNAL(clicked(bool)), iv, SLOT(show(bool)));
 		connect(iv, SIGNAL(visible(bool)), tb, SLOT(setChecked(bool)));
 		connect(this, SIGNAL(updated()), iv, SLOT(updateParent()));

src/frontends/qt4/InsertTableWidget.cpp

@@ -29,8 +29,8 @@
 namespace lyx {
 namespace frontend {
 
-InsertTableWidget::InsertTableWidget(GuiView & lyxView, QWidget * parent)
-	: QWidget(parent, Qt::Popup), colwidth_(20), rowheight_(12), lyxView_(lyxView)
+InsertTableWidget::InsertTableWidget(QWidget * parent)
+	: QWidget(parent, Qt::Popup), colwidth_(20), rowheight_(12)
 {
 	init();
 	setMouseTracking(true);

src/frontends/qt4/InsertTableWidget.h

@@ -24,7 +24,7 @@ class InsertTableWidget : public QWidget {
 	Q_OBJECT
 public:
 
-	InsertTableWidget(GuiView &, QWidget *);
+	InsertTableWidget(QWidget *);
 
 Q_SIGNALS:
 	//! widget is visible
@@ -62,8 +62,6 @@ private:
 	int bottom_;
 	//! column of pointer
 	int right_;
-	//! the lyxview we need to dispatch the funcrequest
-	GuiView & lyxView_;
 	//! widget under mouse
 	bool underMouse_;
 };

src/insets/InsetText.h

@@ -225,8 +225,6 @@ private:
 	///
 	ColorCode frame_color_;
 	///
-	mutable pit_type old_pit;
-	///
 	mutable Text text_;
 };
 

src/mathed/InsetMath.h

@@ -168,8 +168,6 @@ public:
 	/// identifies things that can get \limits or \nolimits
 	virtual bool takesLimits() const { return false; }
 
-	/// char char code if possible
-	virtual void handleFont(docstring const &) {}
 	/// replace things by other things
 	virtual void replace(ReplaceData &) {}
 	/// do we contain a given subsequence?

src/mathed/MathAutoCorrect.cpp

@@ -94,6 +94,7 @@ bool Correction::correct(MathAtom & at, char_type c) const
 }
 
 
+#if 0
 idocstream & operator>>(idocstream & is, Correction & corr)
 {
 	corr.read(is);
@@ -106,7 +107,7 @@ odocstream & operator<<(odocstream & os, Correction & corr)
 	corr.write(os);
 	return os;
 }
-
+#endif
 
 
 

src/mathed/MathData.cpp

@@ -216,6 +216,7 @@ void MathData::touch() const
 }
 
 
+#if 0
 namespace {
 
 bool isInside(DocIterator const & it, MathData const & ar,
@@ -230,7 +231,7 @@ bool isInside(DocIterator const & it, MathData const & ar,
 }
 
 }
-
+#endif
 
 
 void MathData::metrics(MetricsInfo & mi, Dimension & dim) const