anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-12-12 16:50:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Avoid possible overruns by dinamically allocating the required buffer.

Browse Source 
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/branches/BRANCH_1_6_X@33499 a592a061-630c-0410-9148-cb99ea01b6c8
This commit is contained in:
Enrico Forestieri 2010-02-18 09:41:44 +00:00
parent 18b02464b4
commit 67ab913033
1 changed files with 17 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
development/cygwin/lyxeditor.c
View File

@ -30,8 +30,9 @@ void convert_to_full_posix_path(char const * from, char *to)
int main(int ac, char **av) int main(int ac, char **av)
{ {
char buf[2 * PATH_MAX]; char * buf;
char posixpath[PATH_MAX + 1]; int bufsize;
char posixpath[PATH_MAX];
if (ac < 3 || ac > 4) { if (ac < 3 || ac > 4) {
MessageBox(0, "Usage: lyxeditor [-g] <file.tex> <lineno>", MessageBox(0, "Usage: lyxeditor [-g] <file.tex> <lineno>",
@ -40,14 +41,24 @@ int main(int ac, char **av)
} }
if (ac == 3) { if (ac == 3) {
char const * fmt = "lyxeditor.sh" PROGRAM_SUFFIX " '%s' %s";
convert_to_full_posix_path(av[1], posixpath); convert_to_full_posix_path(av[1], posixpath);
sprintf(buf, "lyxeditor.sh" PROGRAM_SUFFIX " '%s' %s", bufsize = snprintf(0, 0, fmt, posixpath, av[2]) + 1;
posixpath, av[2]); if ((buf = malloc(bufsize)))
snprintf(buf, bufsize, fmt, posixpath, av[2]);
} else { } else {
char const * fmt = "lyxclient" PROGRAM_SUFFIX " %s '%s' %s";
convert_to_full_posix_path(av[2], posixpath); convert_to_full_posix_path(av[2], posixpath);
sprintf(buf, "lyxclient" PROGRAM_SUFFIX " %s '%s' %s", bufsize = snprintf(0, 0, fmt, av[1], posixpath, av[3]) + 1;
av[1], posixpath, av[3]); if ((buf = malloc(bufsize)))
snprintf(buf, bufsize, fmt, av[1], posixpath, av[3]);
}
if (!buf) {
MessageBox(0, "Too long arguments", "lyxeditor", 0);
return 1;
} }
system(buf); system(buf);
free(buf);
return 0; return 0;
} }