anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-11-22 10:00:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Effectively disable the "Stop command?" dialog

Browse Source 
We now allow the user to cancel the background process at any point
(via the red "x" in the status bar or Document > Cancel Export), so
we do not need to poll the user with the dialog.

The patch works by setting timeout to "-1" which is treated as a
special value to disable the poll.

Fix (by obviation) #12531 and #9953, which were about the dialog.
This commit is contained in:
Scott Kostyshak 2022-11-25 10:06:59 -05:00
parent 68c7953422
commit 6d4ab79917
2 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/RELEASE-NOTES
View File

@ -3,10 +3,12 @@
!!Interface changes
* It is now possible to cancel background export processes. A menu entry
to do so will appear on the Document menu when such a process is underway.
The LFUN for this is export-cancel. One can also click on the red 'x' next
to the spinner to cancel export.
* It is now possible to cancel background export processes at any time. A menu
entry to do so will appear on the Document menu when such a process is
underway. The LFUN for this is export-cancel. One can also click on the red
'x' next to the spinner to cancel export. Thanks to this functionality, we now
remove the "Stop command?" prompt, which polled users whether to stop a long
process.
* The items on the Edit menu have been reordered, and many of the shortcuts
have been changed so that they are more intuitive in the case of often

9
src/support/os.cpp
View File

@ -47,9 +47,12 @@ namespace os {
int timeout_ms()
{
// return -1 to disable the timeout completely.
// (-1 is a special case in SystemcallPrivate::waitWhile()).
return 3 * 60 * 1000;
// Starting in 2.4.0, we allow the user to cancel the background
// process at any time with LFUN_EXPORT_CANCEL, so the timeout dialog
// is no longer useful.
// "-1" effectively disables the timeout (it is a special case in
// SystemcallPrivate::waitWhile()).
return -1;
}