anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-11-09 18:31:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix display of page references when language is not specified

Browse Source 
Using translateIfPossible with null language does not make sense (and
gives an error on console).

Using translateIfPossible there actually does not make sense at all: it
is only for string from layout files that may already be translated.

We use the buffer language when no language has been specified. It
might have been better to use the GUI language.

A consequence of the commit is that "elsewhere" will be in the po
files and now really translatable ;)
This commit is contained in:
Jean-Marc Lasgouttes 2024-07-05 16:10:17 +02:00
parent 8ba74fe958
commit 6f6d9b631d
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/insets/InsetRef.cpp
View File

@ -32,6 +32,7 @@
#include "support/docstream.h"
#include "support/gettext.h"
#include "support/lstrings.h"
#include "support/Messages.h"
#include "support/textutils.h"
using namespace lyx::support;
@ -399,8 +400,8 @@ docstring InsetRef::displayString(docstring const & ref, string const & cmd,
display_string = value;
else if (cmd == "pageref" || cmd == "vpageref") {
// normally would be "on page #", but we have no pages.
display_string =
translateIfPossible(from_ascii("elsewhere"), language);
display_string = language.empty() ? buffer().B_("elsewhere")
: getMessages(language).get("elsewhere");
} else if (cmd == "eqref")
display_string = '(' + value + ')';
else if (cmd == "formatted") {