From 742b39f49da96eb4881bb3b7b0bbf32be5a226bd Mon Sep 17 00:00:00 2001 From: Scott Kostyshak Date: Sun, 30 Oct 2016 17:50:40 -0400 Subject: [PATCH] Do not open or close branches after doc settings When applying or saving Document Settings, LyX no longer opens or closes branch insets. The intent of the previous code was to open branch insets of a branch that is activated, and close branch insets of a branch that is deactivated. After some discussion [1], it was decided that the behavior intended by the previous code was inconsistent with activating/deactivating a branch in the context-menu of a branch inset, and the previous code assumed a workflow of the user, rather than letting the user separate opening/closing branch insets from activating/deactivating them. This commit modifies fd6cd728. [1] https://www.mail-archive.com/search?l=mid&q=20161030220813.3zlp3zgqgomhx35y%40steph --- src/frontends/qt4/GuiDocument.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/frontends/qt4/GuiDocument.cpp b/src/frontends/qt4/GuiDocument.cpp index f02cdebb17..b1db0e9886 100644 --- a/src/frontends/qt4/GuiDocument.cpp +++ b/src/frontends/qt4/GuiDocument.cpp @@ -4209,10 +4209,6 @@ void GuiDocument::dispatchParams() docstring const str = current_branch + ' ' + from_ascii(x11hexname); dispatch(FuncRequest(LFUN_SET_COLOR, str)); } - - // Open insets of selected branches, close deselected ones - dispatch(FuncRequest(LFUN_INSET_FORALL, - "Branch inset-toggle assign")); } // rename branches in the document executeBranchRenaming();