anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-09-20 06:49:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Do not try to track_change an auto-deleted bibitem

Browse Source 
We are not capable of handling two bibitems within one biblio paragraph.
That's why we have functions like Paragraph::brokenBiblio() and
Paragraph::fixBiblio(). So, if we fix the biblio by deleting the second
bibitem, we should not keep it as deleted.

This code caused a crash because the inset was released, but still kept as
deleted.

Fixes-bug: #8646.
This commit is contained in:
Vincent van Ravesteijn 2014-02-07 15:53:57 +01:00
parent 0ded71a480
commit 795535e44f
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/Paragraph.cpp
View File

@ -3581,8 +3581,7 @@ int Paragraph::fixBiblio(Buffer const & buffer)
// these, which there should be.
// FIXME: why does it make sense to do that rather
// than keep the first? (JMarc)
Inset * inset = d->insetlist_.release(bibitem_pos);
eraseChar(bibitem_pos, track_changes);
Inset * inset = releaseInset(bibitem_pos);
d->insetlist_.begin()->inset = inset;
return -bibitem_pos;
}