anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2025-01-03 08:28:25 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add a check to please coverity.

Browse Source 
Fixes #23496.
This commit is contained in:
Richard Heck 2016-06-12 00:12:03 -04:00
parent 6675601147
commit 7b15ea393f
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/frontends/qt4/GuiView.cpp
View File

@ -2751,9 +2751,13 @@ bool GuiView::closeWorkArea(GuiWorkArea * wa)
bool GuiView::closeBuffer() bool GuiView::closeBuffer()
{ {
GuiWorkArea * wa = currentMainWorkArea(); GuiWorkArea * wa = currentMainWorkArea();
// coverity complained about this
// it seems unnecessary, but perhaps is worth the check
LASSERT(wa, return false);
setCurrentWorkArea(wa); setCurrentWorkArea(wa);
Buffer & buf = wa->bufferView().buffer(); Buffer & buf = wa->bufferView().buffer();
return wa && closeWorkArea(wa, !buf.parent()); return closeWorkArea(wa, !buf.parent());
} }

3
src/frontends/qt4/InGuiThread.h
View File

@ -52,7 +52,8 @@ class InGuiThread : private IntoGuiThreadMover
{ {
public: public:
InGuiThread() {} // please coverity by explicitly initalizing this variable.
InGuiThread() : return_value_(R()) {}
template<class F> template<class F>
R call(F f) R call(F f)