make sure that #warning directives are optional

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/branches/BRANCH_1_3_X@8732 a592a061-630c-0410-9148-cb99ea01b6c8

src/ChangeLog

@@ -1,5 +1,11 @@
 2004-04-29  Jean-Marc Lasgouttes  <lasgouttes@lyx.org>
 
+	* text2.C (setCounter): 
+	* lyxfunc.C (dispatch): 
+	* exporter.C (Export): 
+	* converter.C (runLaTeX): 
+	* buffer.C (redraw, runChktex): fix #warning directives
+
 	* BoostFormat.h: fix compilation with gcc 3.4
 
 2003-09-24  Jean-Marc Lasgouttes  <lasgouttes@lyx.org>

src/buffer.C

@@ -3161,7 +3161,9 @@ int Buffer::runChktex()
 	// if we removed error insets before we ran chktex or if we inserted
 	// error insets after we ran chktex, this must be run:
 	if (removedErrorInsets || res) {
+#ifdef WITH_WARNINGS
 #warning repaint needed here, or do you mean update() ?
+#endif
 		users->repaint();
 		users->fitCursor();
 	}
@@ -3349,7 +3351,9 @@ void Buffer::resizeInsets(BufferView * bv)
 
 void Buffer::redraw()
 {
+#ifdef WITH_WARNINGS
 #warning repaint needed here, or do you mean update() ?
+#endif
 	users->repaint();
 	users->fitCursor();
 }

src/converter.C

@@ -908,7 +908,9 @@ bool Converters::runLaTeX(Buffer const * buffer, string const & command)
 		if ((result & LaTeX::ERRORS)) {
 			// Insert all errors as errors boxes
 			bv->insertErrors(terr);
+#ifdef WITH_WARNINGS
 #warning repaint() or update() or nothing ?
+#endif
 			bv->repaint();
 			bv->fitCursor();
 		}

src/exporter.C

@@ -39,7 +39,9 @@ bool Exporter::Export(Buffer * buffer, string const & format,
 	if (bv) {
 		// Remove all error insets
 		if (bv->removeAutoInsets()) {
+#ifdef WITH_WARNINGS
 #warning repaint() or update() or nothing ?
+#endif
 			bv->repaint();
 			bv->fitCursor();
 		}

src/frontends/controllers/ChangeLog

@@ -1,5 +1,9 @@
 2004-04-29  Jean-Marc Lasgouttes  <lasgouttes@lyx.org>
 
+	* ControlMath.C (find_xpm): 
+	* ControlBibtex.C (applyParamsToInset): 
+	* ControlBibitem.C (applyParamsToInset): fix #warning directives
+	
 	* ControlDialog.tmpl (show, update, hide): gcc 3.4 compilation fix
 
 2003-02-10  Jean-Marc Lasgouttes  <lasgouttes@freesurf.fr>

src/frontends/controllers/ControlBibitem.C

@@ -37,8 +37,10 @@ void ControlBibitem::applyParamsToInset()
 
 	// We need to do a redraw because the maximum
 	// InsetBibKey width could have changed
+#ifdef WITH_WARNINGS
 #warning please check you mean repaint() not update(),
 #warning and whether the repaint() is needed at all
+#endif
 	bufferview()->repaint();
 	bufferview()->fitCursor();
 }

src/frontends/controllers/ControlBibtex.C

@@ -46,7 +46,9 @@ void ControlBibtex::applyParamsToInset()
 
 	// We need to do a redraw because the maximum
 	// InsetBibKey width could have changed
+#ifdef WITH_WARNINGS
 #warning are you sure you need this repaint() ?
+#endif
 	bufferview()->repaint();
 	bufferview()->fitCursor();
 }

src/frontends/controllers/ControlMath.C

@@ -301,9 +301,10 @@ int const nr_latex_ams_ops = sizeof(latex_ams_ops) / sizeof(char const *);
 
 string const find_xpm(string const & name)
 {
+#ifdef WITH_WARNINGS
 #warning Use a static table for this (Lgb)
 	// And get O(log n) lookup (Lgb)
-
+#endif
 	string xpm_name = subst(name, ' ', '_');
 	if (xpm_name == "(") xpm_name = "lparen";
 	else if (xpm_name == ")") xpm_name = "rparen";

src/frontends/qt2/ChangeLog

@@ -1,5 +1,7 @@
 2004-04-29  Jean-Marc Lasgouttes  <lasgouttes@lyx.org>
 
+	* QBrowseBox.C: add using directive
+
 	* Qt2Base.h (controller): gcc 3.4 compilation fix
 
 2004-01-22  Jean-Marc Lasgouttes  <lasgouttes@lyx.org>

src/frontends/qt2/QBrowseBox.C

@@ -24,6 +24,7 @@
 #include <cstdio>
 #include <cmath>
 
+using std::floor;
 
 QBrowseBox::QBrowseBox(int rows, int cols, QWidget* parent, const char* name, WFlags f)
 	: QGridView(parent,name,f)

src/insets/ChangeLog

@@ -1,3 +1,7 @@
+2004-04-29  Jean-Marc Lasgouttes  <lasgouttes@lyx.org>
+
+	* insetcite.C (latex): fix #warning statement
+
 2004-04-19  Jean-Marc Lasgouttes  <lasgouttes@lyx.org>
 
 	* insetbib.C (normalize_name): new helper function. This changes

src/insets/insetcite.C

@@ -364,8 +364,9 @@ int InsetCitation::latex(Buffer const * buffer, ostream & os,
 		os << getCmdName();
 	else
 		os << "cite";
-
+#ifdef WITH_WARNINGS
 #warning What is this code supposed to do? (Lgb)
+#endif
 // my guess is that this is just waiting for when we support before,
 // so it's a oneliner. But this is very silly ! - jbl
 

src/lyxfunc.C

@@ -833,7 +833,9 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
 				owner->view_state_changed();
 				goto exit_with_message;
 			}
+#ifdef WITH_WARNINGS
 #warning I am not sure this is still right, please have a look! (Jug 20020417)
+#endif
 			else { // result == UNDISPATCHED
 				//setMessage(N_("Text mode"));
 				switch (action) {
@@ -1083,7 +1085,9 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
 
 	case LFUN_REMOVEERRORS:
 		if (view()->removeAutoInsets()) {
+#ifdef WITH_WARNINGS
 #warning repaint() or update() or nothing ?
+#endif
 			view()->repaint();
 			view()->fitCursor();
 		}
@@ -1116,10 +1120,6 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
 		else if (argument == "closefig")
 			view()->allFloats(0,1);
 		break;
-#else
-#ifdef WITH_WARNINGS
-//#warning Find another implementation here (or another lyxfunc)!
-#endif
 #endif
 	case LFUN_HELP_ABOUTLYX:
 		owner->getDialogs().showAboutlyx();

src/mathed/ChangeLog

@@ -1,3 +1,8 @@
+2004-04-29  Jean-Marc Lasgouttes  <lasgouttes@lyx.org>
+
+	* math_hullinset.C (dispatch): 
+	* math_diminset.C (metricsT): fix #warning directives
+
 2004-03-26  Jean-Marc Lasgouttes  <lasgouttes@lyx.org>
 
 	* math_gridinset.C (MathGridInset): add destructor, to fix link

src/mathed/math_diminset.C

@@ -9,7 +9,7 @@
 
 void MathDimInset::metricsT(TextMetricsInfo const &) const
 {
-#ifndef WITH_WARNINGS
+#ifdef WITH_WARNINGS
 #warning temporarily disabled
 #endif
 /*

src/mathed/math_hullinset.C

@@ -807,9 +807,10 @@ MathInset::result_type MathHullInset::dispatch
 
 			if (!new_label.empty())
 				numbered(r, true);
-
+#ifdef WITH_WARNINGS
 #warning FIXME: please check you really mean repaint() ... is it needed,
 #warning and if so, should it be update() instead ?
+#endif
 			if (!new_label.empty()
 					&& cmd.view()->ChangeRefsIfUnique(old_label, new_label))
 				cmd.view()->repaint();

src/text2.C

@@ -1321,7 +1321,9 @@ void LyXText::setCounter(Buffer const * buf, Paragraph * par) const
 				textclass.counters().step(fl.type());
 
 				// Doesn't work... yet.
+#ifdef WITH_WARNINGS
 #warning use boost.format
+#endif
 #if USE_BOOST_FORMAT
 				s = boost::io::str(boost::format(_("%1$s #:")) % fl.name());
 				// s << boost::format(_("%1$s %1$d:")