mirror of
https://git.lyx.org/repos/lyx.git
synced 2024-11-07 02:28:35 +00:00
Remove unwanted clearSelection()s in MathData::updateMacros(). These calls broke text selection with keyboard and mouse, search-and-replace, restoring selection after Undo, etc. in a document with math macros since 1.6.0. (Regression at6aa54673
and12314897
) I do not know the purpose of these calls, but the selection code has been worked on since, and I cannot produce undesired behaviour after removing them.
This commit is contained in:
parent
21c30a09e1
commit
89342f2946
@ -433,13 +433,8 @@ void MathData::updateMacros(Cursor * cur, MacroContext const & mc,
|
||||
if (oldDisplayMode == MathMacro::DISPLAY_NORMAL
|
||||
&& (macroInset->arity() != macroNumArgs
|
||||
|| macroInset->optionals() != macroOptionals
|
||||
|| newDisplayMode == MathMacro::DISPLAY_UNFOLDED)) {
|
||||
|
||||
|| newDisplayMode == MathMacro::DISPLAY_UNFOLDED))
|
||||
detachMacroParameters(cur, i);
|
||||
// FIXME: proper anchor handling, this removes the selection
|
||||
if (cur)
|
||||
cur->clearSelection();
|
||||
}
|
||||
|
||||
// the macro could have been copied while resizing this
|
||||
macroInset = operator[](i).nucleus()->asMacro();
|
||||
@ -478,11 +473,8 @@ void MathData::updateMacros(Cursor * cur, MacroContext const & mc,
|
||||
attachMacroParameters(cur, i, macroNumArgs, macroOptionals,
|
||||
fromInitToNormalMode, interactive, appetite);
|
||||
|
||||
if (cur) {
|
||||
// FIXME: proper anchor handling, this removes the selection
|
||||
if (cur)
|
||||
cur->updateInsets(&cur->bottom().inset());
|
||||
cur->clearSelection();
|
||||
}
|
||||
}
|
||||
|
||||
// Give macro the chance to adapt to new situation.
|
||||
|
Loading…
Reference in New Issue
Block a user