Avoid a couple of copies.

Spotted by Coverity scan.
This commit is contained in:
Jean-Marc Lasgouttes 2024-09-12 18:33:45 +02:00
parent 7a99ef7fbb
commit 8e181e992d

View File

@ -1725,10 +1725,6 @@ void MenuDefinition::expandCiteStyles(BufferView const * bv)
&& (keys.size() > 1 && (keys.size() > 1
|| !citinset->getParam("pretextlist").empty() || !citinset->getParam("pretextlist").empty()
|| !citinset->getParam("posttextlist").empty()); || !citinset->getParam("posttextlist").empty());
vector<pair<docstring, docstring>> pres =
citinset->getQualifiedLists(citinset->getParam("pretextlist"));
vector<pair<docstring, docstring>> posts =
citinset->getQualifiedLists(citinset->getParam("posttextlist"));
CiteItem ci; CiteItem ci;
ci.textBefore = citinset->getParam("before"); ci.textBefore = citinset->getParam("before");
@ -1738,8 +1734,10 @@ void MenuDefinition::expandCiteStyles(BufferView const * bv)
ci.context = CiteItem::Dialog; ci.context = CiteItem::Dialog;
ci.max_size = 40; ci.max_size = 40;
ci.isQualified = qualified; ci.isQualified = qualified;
ci.pretexts = pres; ci.pretexts =
ci.posttexts = posts; citinset->getQualifiedLists(citinset->getParam("pretextlist"));
ci.posttexts =
citinset->getQualifiedLists(citinset->getParam("posttextlist"));
BiblioInfo::CiteStringMap citeStrings = BiblioInfo::CiteStringMap citeStrings =
buf->masterBibInfo().getCiteStrings(keys, citeStyleList, bv->buffer(), ci); buf->masterBibInfo().getCiteStrings(keys, citeStyleList, bv->buffer(), ci);