From 90a524a0751490caaa58eef140dcf785e2df2151 Mon Sep 17 00:00:00 2001 From: Georg Baum Date: Sun, 7 Jun 2015 10:32:32 +0200 Subject: [PATCH] Fix comments The FIXME is not needed, this is how StyleChanger and FracChanger work: In the constructor, they change the state of the FontInfo, and in the destructor the state is set back. Therefore, all code that needs the changed state, needs to be executed while the objects do still exist. --- src/mathed/InsetMathFrac.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mathed/InsetMathFrac.cpp b/src/mathed/InsetMathFrac.cpp index 6a175fad31..467735558c 100644 --- a/src/mathed/InsetMathFrac.cpp +++ b/src/mathed/InsetMathFrac.cpp @@ -553,8 +553,8 @@ void InsetMathBinom::metrics(MetricsInfo & mi, Dimension & dim) const { Dimension dim0, dim1; - // FIXME: for an unknown reason the cells must be set directly - // after the StyleChanger and cannot be set after the if case + // The cells must be set while the RAII objects (StyleChanger, + // FracChanger) do still exist and cannot be set after the if case. if (kind_ == DBINOM) { StyleChanger dummy(mi.base, LM_ST_DISPLAY); cell(0).metrics(mi, dim0); @@ -587,8 +587,8 @@ void InsetMathBinom::draw(PainterInfo & pi, int x, int y) const kind_ == BRACK ? from_ascii("]") : from_ascii(")"); int m = x + dim.width() / 2; - // FIXME: for an unknown reason the cells must be drawn directly - // after the StyleChanger and cannot be drawn after the if case + // The cells must be drawn while the RAII objects (StyleChanger, + // FracChanger) do still exist and cannot be drawn after the if case. if (kind_ == DBINOM) { StyleChanger dummy(pi.base, LM_ST_DISPLAY); cell(0).draw(pi, m - dim0.wid / 2, y - dim0.des - 3 - 5);