anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-11-14 23:12:31 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

TocWidget: Fix perf regression

Browse Source 
4d1ad336 fixed #9754 but caused perf issues by cancelling the gains of having a
timer (introduced after #7138). This introduces in GuiToc::enableView() a
lightweight check of whether the widget should be updated. The logic is inspired
from GuiViewSource::enableView().
This commit is contained in:
Guillaume Munch 2016-04-30 00:25:46 +01:00
parent 5b976a5ebc
commit 90c8b0697f
3 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/frontends/qt4/GuiToc.cpp
View File

@ -66,8 +66,11 @@ void GuiToc::dispatchParams()
}
void GuiToc::enableView(bool /*enable*/)
void GuiToc::enableView(bool enable)
{
widget_->checkModelChanged();
if (!enable)
// In the opposite case, updateView() will be called anyway.
widget_->updateViewForce();
}

8
src/frontends/qt4/TocWidget.cpp
View File

@ -452,6 +452,14 @@ void TocWidget::updateViewForce()
}
void TocWidget::checkModelChanged()
{
if (!gui_view_.documentBufferView() ||
gui_view_.tocModels().model(current_type_) != tocTV->model())
updateViewForce();
}
void TocWidget::filterContents()
{
if (!tocTV->model())

2
src/frontends/qt4/TocWidget.h
View File

@ -42,6 +42,8 @@ public:
///
bool getStatus(Cursor & cur, FuncRequest const & fr, FuncStatus & status)
const;
// update the view when the model has changed
void checkModelChanged();
public Q_SLOTS:
/// Schedule new update of the display unless already scheduled.