anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-11-26 11:16:55 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fic crash for repeated pasting from complex docs

Browse Source 
Using a cloned buffer was an idea by Richard, and it works well.
This commit is contained in:
Georg Baum 2013-04-21 21:15:54 +02:00
parent ed2f6a8599
commit 928dc03324
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/CutAndPaste.cpp
View File

@ -478,12 +478,17 @@ void putClipboard(ParagraphList const & paragraphs,
// to be so, but the alternative is to construct a new one of these (with a
// new temporary directory, etc) every time, and then to destroy it. So maybe
// it's worth just keeping this one around.
static Buffer * buffer = theBufferList().newInternalBuffer(
Buffer * staticbuffer = theBufferList().newInternalBuffer(
FileName::tempName("clipboard.internal").absFileName());
// These two things only really need doing the first time.
buffer->setUnnamed(true);
buffer->inset().setBuffer(*buffer);
staticbuffer->setUnnamed(true);
staticbuffer->inset().setBuffer(*staticbuffer);
// Use a clone for the complicated stuff so that we do not need to clean
// up in order to avoid a crash.
Buffer * buffer = staticbuffer->cloneBufferOnly();
LASSERT(buffer, return);
// This needs doing every time.
buffer->params().setDocumentClass(docclass);
@ -521,7 +526,7 @@ void putClipboard(ParagraphList const & paragraphs,
theClipboard().put(lyx, oshtml.str(), plaintext);
// Save that memory
buffer->paragraphs().clear();
delete buffer;
}