Fix bug 2179

* controllers/ControlErrorList.h (unreadlist_): new member, tells whether the
  errorlist has been read by the dialog.

  * controllers/ControlErrorList.C (errorList, initialiseParams): update
  unreadlist_ as needed.

  * qt2/QErrorList.C (update_contents): do nothing if error list has not
  been updated (bug 2179).

  * xforms/FormErrorList.C (update): do not call updateContents if the
  error list has not been updated (bug 2179).



git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/branches/BRANCH_1_4_X@14655 a592a061-630c-0410-9148-cb99ea01b6c8
This commit is contained in:
Jean-Marc Lasgouttes 2006-08-13 17:39:36 +00:00
parent 5149b75620
commit 9f12b59a91
8 changed files with 42 additions and 4 deletions

View File

@ -1,3 +1,11 @@
2006-08-13 Jean-Marc Lasgouttes <lasgouttes@lyx.org>
* ControlErrorList.h (unreadlist_): new member, tells whether the
errorlist has been read by the dialog.
* ControlErrorList.C (errorList, initialiseParams): update
unreadlist_ as needed.
2006-07-04 Bo Peng <ben.bob@gmail.com> 2006-07-04 Bo Peng <ben.bob@gmail.com>
* tex_helpers.C (rescanTexStyles): invoke the new TeXFiles.py * tex_helpers.C (rescanTexStyles): invoke the new TeXFiles.py

View File

@ -25,7 +25,7 @@ namespace lyx {
namespace frontend { namespace frontend {
ControlErrorList::ControlErrorList(Dialog & d) ControlErrorList::ControlErrorList(Dialog & d)
: Dialog::Controller(d) : Dialog::Controller(d), unreadlist_(true)
{} {}
@ -33,8 +33,9 @@ void ControlErrorList::clearParams()
{} {}
ErrorList const & ControlErrorList::errorList() const ErrorList const & ControlErrorList::errorList()
{ {
unreadlist_ = false;
return errorlist_; return errorlist_;
} }
@ -42,11 +43,18 @@ ErrorList const & ControlErrorList::errorList() const
bool ControlErrorList::initialiseParams(string const & name) bool ControlErrorList::initialiseParams(string const & name)
{ {
errorlist_ = kernel().bufferview()->getErrorList(); errorlist_ = kernel().bufferview()->getErrorList();
unreadlist_ = true;
name_ = name; name_ = name;
return true; return true;
} }
bool ControlErrorList::hasUnreadList() const
{
return unreadlist_;
}
string const & ControlErrorList::name() string const & ControlErrorList::name()
{ {
return name_; return name_;

View File

@ -38,12 +38,17 @@ public:
/// return the parent document name /// return the parent document name
std::string const & name(); std::string const & name();
/// ///
ErrorList const & errorList() const; ErrorList const & errorList();
/// return true when the error list has been updated, but
/// \c errorlist() has not been called.
bool hasUnreadList() const;
private: private:
/// ///
ErrorList errorlist_; ErrorList errorlist_;
/// ///
std::string name_; std::string name_;
///
bool unreadlist_;
}; };
} // namespace frontend } // namespace frontend

View File

@ -1,3 +1,8 @@
2006-08-13 Jean-Marc Lasgouttes <lasgouttes@lyx.org>
* QErrorList.C (update_contents): do nothing if error list has not
been updated (bug 2179).
2006-07-13 Jean-Marc Lasgouttes <lasgouttes@lyx.org> 2006-07-13 Jean-Marc Lasgouttes <lasgouttes@lyx.org>
* QContentPane.C (q_key_state): allow both Alt and Meta as alt * QContentPane.C (q_key_state): allow both Alt and Meta as alt

View File

@ -47,6 +47,10 @@ void QErrorList::select(int item)
void QErrorList::update_contents() void QErrorList::update_contents()
{ {
// is there something to do?
if (!controller().hasUnreadList())
return;
setTitle(controller().name()); setTitle(controller().name());
dialog_->errorsLB->clear(); dialog_->errorsLB->clear();
dialog_->descriptionTB->setText(QString()); dialog_->descriptionTB->setText(QString());

View File

@ -1,3 +1,8 @@
2006-08-13 Jean-Marc Lasgouttes <lasgouttes@lyx.org>
* FormErrorList.C (update): do not call updateContents if the
error list has not been updated (bug 2179).
2006-06-27 Martin Vermeer <martin.vermeer@hut.fi> 2006-06-27 Martin Vermeer <martin.vermeer@hut.fi>
* FormSpellchecker.C (update): fix bug 2218: Spellchecker doesn't * FormSpellchecker.C (update): fix bug 2218: Spellchecker doesn't

View File

@ -44,6 +44,7 @@ void FormErrorList::build()
void FormErrorList::update() void FormErrorList::update()
{ {
setTitle(controller().name()); setTitle(controller().name());
if (controller().hasUnreadList())
updateContents(); updateContents();
} }

View File

@ -60,6 +60,8 @@ What's new
- Fix lockup when accepting a change in a text inset (bug 2510). - Fix lockup when accepting a change in a text inset (bug 2510).
- Fix editing of document while Error List dialog is open (bug 2179).
- Update labels on screen when changing language. - Update labels on screen when changing language.
- Show an error box when failing to update the TeX Information dalog data. - Show an error box when failing to update the TeX Information dalog data.