GuiDialog.cpp: remove question marks from Windows dialogs

backported from master, fixes bug #10098, patch from Guillaume

src/frontends/qt4/DialogView.h

@@ -30,7 +30,10 @@ public:
 	/// \param title is the window title used for decoration.
 	DialogView(GuiView & lv, QString const & name, QString const & title)
 		: QDialog(&lv), Dialog(lv, name, "LyX: " + title)
-	{}
+	{
+		// remove question marks from Windows dialogs
+		setWindowFlags(windowFlags() & ~Qt::WindowContextHelpButtonHint);
+	} 
 
 	virtual QWidget * asQWidget() { return this; }
 	virtual QWidget const * asQWidget() const { return this; }

src/frontends/qt4/GuiDialog.cpp

@@ -27,7 +27,10 @@ namespace frontend {
 GuiDialog::GuiDialog(GuiView & lv, QString const & name, QString const & title)
 	: QDialog(&lv), Dialog(lv, name, "LyX: " + title), updating_(false), 
 	  is_closing_(false)
-{}
+{
+	// remove question marks from Windows dialogs
+	setWindowFlags(windowFlags() & ~Qt::WindowContextHelpButtonHint);
+} 
 
 
 void GuiDialog::closeEvent(QCloseEvent * ev)

src/frontends/qt4/LyXFileDialog.cpp

@@ -51,6 +51,7 @@ LyXFileDialog::LyXFileDialog(QString const & title,
 {
 	setNameFilters(filters);
 	setWindowTitle(title);
+	setWindowFlags(windowFlags() & ~Qt::WindowContextHelpButtonHint);
 	setOption(QFileDialog::DontUseNativeDialog);
 
 	QList<QHBoxLayout *> layout = findChildren<QHBoxLayout *>();

status.22x

@@ -68,6 +68,8 @@ What's new
 - Fix regression that was not allowing inserting more than three consecutive
   dashes without jumping through hoops.
 
+- Remove the unused question mark button in dialogs on Windows (bug 10098).
+
 
 * DOCUMENTATION AND LOCALIZATION