The mechanism for closing font tags at the end of a paragraph was

throwing errors in the case where we are inside a charstyle that itself
uses a font tag, e.g., strong from the logical markup module. This at
least gets rid of most of the errors, and doesn't seem to cause any
other problems.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@38220 a592a061-630c-0410-9148-cb99ea01b6c8

src/Paragraph.cpp

@@ -2734,6 +2734,8 @@ docstring Paragraph::simpleLyXHTMLOnePar(Buffer const & buf,
 
 	Layout const & style = *d->layout_;
 
+	xs.startParagraph();
+
 	if (!runparams.for_toc && runparams.html_make_pars) {
 		// generate a magic label for this paragraph
 		string const attr = "id='" + magicLabel() + "'";
@@ -2813,6 +2815,7 @@ docstring Paragraph::simpleLyXHTMLOnePar(Buffer const & buf,
 	}
 
 	xs.closeFontTags();
+	xs.endParagraph();
 	return retval;
 }
 

src/output_xhtml.cpp

@@ -205,6 +205,12 @@ void XHTMLStream::writeError(std::string const & s)
 }
 
 
+namespace {
+	// an illegal tag for internal use
+	static string const parsep_tag = "&LyX_parsep_tag&";
+}
+
+
 bool XHTMLStream::closeFontTags()
 {
 	if (tag_stack_.empty())
@@ -221,19 +227,76 @@ bool XHTMLStream::closeFontTags()
 			return true;
 		curtag = tag_stack_.back();
 	}
-	// so we've hit a non-font tag. let's see if any of the
+
-	// remaining tags are font tags.
+	if (curtag.tag_ == parsep_tag)
-	TagStack::const_iterator it = tag_stack_.begin();
+		return true;
-	TagStack::const_iterator en = tag_stack_.end();
+
-	bool noFontTags = true;
+	// so we've hit a non-font tag.
+	writeError("Tags still open in closeFontTags(). Probably not a problem,\n"
+	           "but you might want to check these tags:");
+	TagStack::const_reverse_iterator it = tag_stack_.rbegin();
+	TagStack::const_reverse_iterator const en = tag_stack_.rend();
 	for (; it != en; ++it) {
-		if (html::isFontTag(it->tag_)) {
+		string const tagname = it->tag_;
-			writeError("Font tag `" + it->tag_ + "' still open in closeFontTags().\n"
+		if (tagname == parsep_tag)
-				"This is likely not a problem, but you might want to check.");
+			break;
-			noFontTags = false;
+		writeError(it->tag_);
 		}
 	}
-	return noFontTags;
+	return false;
+}
+
+
+void XHTMLStream::startParagraph()
+{
+	pending_tags_.push_back(html::StartTag(parsep_tag));
+}
+
+
+void XHTMLStream::endParagraph()
+{
+	if (!isTagOpen(parsep_tag)) {
+		// is it pending?
+		TagStack::const_iterator dit = pending_tags_.begin();
+		TagStack::const_iterator const den = pending_tags_.end();
+		bool found = false;
+		for (; dit != den; ++dit) {
+			if (dit->tag_ == parsep_tag) {
+				found = true;
+				break;
+			}
+		}
+
+		if (!found) {
+			writeError("No paragraph separation tag found in endParagraph().");
+			return;
+		}
+		
+		// this case is normal.
+		while (!pending_tags_.empty()) {
+			// clear all pending tags up to and including the parsep tag.
+			// note that we work from the back, because we want to get rid
+			// of everything that hasnt' been used.
+			html::StartTag const cur_tag = pending_tags_.back();
+			string const & tag = cur_tag.tag_;
+			tag_stack_.pop_back();
+			if (tag == parsep_tag)
+				break;
+		}
+		return;
+	}
+
+	// this case is also normal, if the parsep tag is the last one 
+	// on the stack. otherwise, it's an error.
+	while (!tag_stack_.empty()) {
+		html::StartTag const cur_tag = tag_stack_.back();
+		string const & tag = cur_tag.tag_;
+		tag_stack_.pop_back();
+		if (tag == parsep_tag)
+			break;
+		writeError("Tag `" + tag + "' still open at end of paragraph. Closing.");
+		os_ << cur_tag.asEndTag();
+	}
 }
 
 
@@ -241,8 +304,9 @@ void XHTMLStream::clearTagDeque()
 {
 	while (!pending_tags_.empty()) {
 		html::StartTag const & tag = pending_tags_.front();
-		// tabs?
+		if (tag.tag_ != parsep_tag)
-		os_ << tag.asTag();
+			// tabs?
+			os_ << tag.asTag();
 		tag_stack_.push_back(tag);
 		pending_tags_.pop_front();
 	}
@@ -476,7 +540,8 @@ XHTMLStream & XHTMLStream::operator<<(html::EndTag const & etag)
 	html::StartTag curtag = tag_stack_.back();
 	while (curtag.tag_ != etag.tag_) {
 		writeError(curtag.tag_);
-		os_ << curtag.asEndTag();
+		if (curtag.tag_ != parsep_tag)
+			os_ << curtag.asEndTag();
 		tag_stack_.pop_back();
 		curtag = tag_stack_.back();
 	}

src/output_xhtml.h

@@ -101,6 +101,12 @@ public:
 	/// \return false if there are open font tags we could not close.
 	/// because they are "blocked" by open non-font tags on the stack.
 	bool closeFontTags();
+	/// call at start of paragraph. sets a mark so we know what tags
+	/// to close at the end. 
+	void startParagraph();
+	/// call at end of paragraph to clear that mark. note that this
+	/// will also close any tags still open. 
+	void endParagraph();
 	///
 	XHTMLStream & operator<<(docstring const &);
 	///