From a8937b53ecb054e140036b742e0c529bf8c9937a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Matos?= Date: Mon, 3 Jun 2019 17:15:09 +0100 Subject: [PATCH] Fix bug in python comparison. It worked in python2 but not the way the authors imagined. Because hex always returns a string. From python2: >>> 1 > "2" False >>> "2" > 1 True >>> "1" > 2 True The rational is that an integer is always smaller than a string. In python 3 this because it does not make sense to compare objects of different types. --- lib/scripts/convertDefault.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/scripts/convertDefault.py b/lib/scripts/convertDefault.py index 418b553758..eee533d5ea 100644 --- a/lib/scripts/convertDefault.py +++ b/lib/scripts/convertDefault.py @@ -72,7 +72,7 @@ if sys.argv[1] == 'pdf' and (version >= 0x060206 or gm): sopts = '-define pdf:use-cropbox=true ' + sopts # If supported, add the -flatten option for ppm target formats (see bug 4749) -if sys.argv[3] == 'ppm' and (im and version >= 0x060305 or gm): +if sys.argv[3] == 'ppm' and (im and version >= "0x060305" or gm): topts = '-flatten' # print (command, sys.argv[2], sys.argv[4], file= sys.stdout)