Try another way of convincing coverity that everything is fine

We have a false positive here, but annotating with coverity[] comments
is not very convenient. Let's try to use good old assertions instead.
This commit is contained in:
Jean-Marc Lasgouttes 2017-04-04 09:35:55 +02:00
parent d683cc2147
commit aa62b1ad49

View File

@ -36,6 +36,7 @@
#include "frontends/alert.h" #include "frontends/alert.h"
#include "support/lassert.h"
#include "support/convert.h" #include "support/convert.h"
#include "support/debug.h" #include "support/debug.h"
#include "support/docstream.h" #include "support/docstream.h"
@ -67,11 +68,12 @@ InsetBibitem::InsetBibitem(Buffer * buf, InsetCommandParams const & p)
InsetBibitem::~InsetBibitem() InsetBibitem::~InsetBibitem()
{ {
if (isBufferLoaded()) if (isBufferLoaded()) {
/* Coverity believes that this may throw an exception, but /* Coverity believes that this may throw an exception, but
* actually this code path is not taken when buffer_ == 0 */ * actually this code path is not taken when buffer_ == 0 */
// coverity[fun_call_w_exception] LATTEST(buffer_);
buffer().invalidateBibinfoCache(); buffer().invalidateBibinfoCache();
}
} }