anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-12-23 05:25:26 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove redundant code and clarify strings

Browse Source
This commit is contained in:
Juergen Spitzmueller 2023-09-02 14:28:33 +02:00
parent 669774020f
commit aaae3ad5cc
1 changed files with 2 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/frontends/qt/GuiDocument.cpp
View File

@ -2178,30 +2178,6 @@ void GuiDocument::setMargins()
marginsModule->marginCB->setChecked(!bp_.use_geometry); marginsModule->marginCB->setChecked(!bp_.use_geometry);
setCustomMargins(!bp_.use_geometry); setCustomMargins(!bp_.use_geometry);
} }
// set some placeholder text that hint on defaults
QString const placeholder = marginsModule->marginCB->isChecked() ?
qt_("Class defaults") : qt_("Package defaults");
// set tooltip depending on gemoetry state
QString const tooltip = marginsModule->marginCB->isChecked() ?
qt_("If no value is given, the defaults as set by the class are used.")
: qt_("If no value is given, the defaults as set by the geometry package or a package/class overriding geometry's defaults are used.");
marginsModule->topLE->setPlaceholderText(placeholder);
marginsModule->bottomLE->setPlaceholderText(placeholder);
marginsModule->innerLE->setPlaceholderText(placeholder);
marginsModule->outerLE->setPlaceholderText(placeholder);
marginsModule->headheightLE->setPlaceholderText(placeholder);
marginsModule->headsepLE->setPlaceholderText(placeholder);
marginsModule->footskipLE->setPlaceholderText(placeholder);
marginsModule->columnsepLE->setPlaceholderText(placeholder);
marginsModule->topLE->setToolTip(tooltip);
marginsModule->bottomLE->setToolTip(tooltip);
marginsModule->innerLE->setToolTip(tooltip);
marginsModule->outerLE->setToolTip(tooltip);
marginsModule->headheightLE->setToolTip(tooltip);
marginsModule->headsepLE->setToolTip(tooltip);
marginsModule->footskipLE->setToolTip(tooltip);
marginsModule->columnsepLE->setToolTip(tooltip);
} }
@ -2267,10 +2243,10 @@ void GuiDocument::setCustomMargins(bool custom)
// set some placeholder text that hint on defaults // set some placeholder text that hint on defaults
QString const placeholder = marginsModule->marginCB->isChecked() ? QString const placeholder = marginsModule->marginCB->isChecked() ?
qt_("Class defaults") : qt_("Package defaults"); qt_("Default margins") : qt_("Package defaults");
// set tooltip depending on gemoetry state // set tooltip depending on gemoetry state
QString const tooltip = marginsModule->marginCB->isChecked() ? QString const tooltip = marginsModule->marginCB->isChecked() ?
qt_("If no value is given, the defaults as set by the class are used.") qt_("If no value is given, the defaults as set by the class, a package or the preamble are used.")
: qt_("If no value is given, the defaults as set by the geometry package or a package/class overriding geometry's defaults are used."); : qt_("If no value is given, the defaults as set by the geometry package or a package/class overriding geometry's defaults are used.");
marginsModule->topLE->setPlaceholderText(placeholder); marginsModule->topLE->setPlaceholderText(placeholder);
marginsModule->bottomLE->setPlaceholderText(placeholder); marginsModule->bottomLE->setPlaceholderText(placeholder);
@ -2288,7 +2264,6 @@ void GuiDocument::setCustomMargins(bool custom)
marginsModule->headsepLE->setToolTip(tooltip); marginsModule->headsepLE->setToolTip(tooltip);
marginsModule->footskipLE->setToolTip(tooltip); marginsModule->footskipLE->setToolTip(tooltip);
marginsModule->columnsepLE->setToolTip(tooltip); marginsModule->columnsepLE->setToolTip(tooltip);
} }