anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-09-19 22:40:26 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Avoid swapping a cell with itself

Browse Source 
Gcc STL debugging feature asserts when swapping an object with itself. This happens in some cases with math grids that have only one column.

A quick review of other uses of swap() in the code base did not reveal any other dubious case.

Fixes bug #9902.
This commit is contained in:
Jean-Marc Lasgouttes 2015-12-23 11:05:28 +01:00
parent 1f8fd79c41
commit b01f7a6bdd
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/mathed/InsetMathGrid.cpp
View File

@ -1194,7 +1194,8 @@ void InsetMathGrid::doDispatch(Cursor & cur, FuncRequest & cmd)
// split cell
splitCell(cur);
swap(cell(cur.idx()), cell(cur.idx() + ncols() - 1));
if (ncols() > 1)
swap(cell(cur.idx()), cell(cur.idx() + ncols() - 1));
if (cur.idx() > 0)
--cur.idx();
cur.pos() = cur.lastpos();

2
status.21x
View File

@ -83,6 +83,8 @@ What's new
- Fix crash when unfolding/copying macros containing other macros (bug 9490).
- Fix crash when inserting a line in multline math environment (bug 9902).
- Fix automatic insertion of longtable captions (bug 9692).
- Fix setting of nested minipage via the dialog (bug 8716).