Add some const-ref-ness, and remove some default arguments that are

never treated as defaults.
This commit is contained in:
Richard Heck 2014-05-23 11:03:17 -04:00
parent 344ea62dd0
commit ba17d842b4
2 changed files with 8 additions and 8 deletions

View File

@ -641,7 +641,8 @@ docstring const & BibTeXInfo::getInfo(BibTeXInfo const * const xref,
docstring const BibTeXInfo::getLabel(BibTeXInfo const * const xref, docstring const BibTeXInfo::getLabel(BibTeXInfo const * const xref,
Buffer const & buf, docstring const & format, bool richtext, Buffer const & buf, docstring const & format, bool richtext,
docstring before, docstring after, docstring dialog, bool next) const docstring const & before, docstring const & after,
docstring const & dialog, bool next) const
{ {
docstring loclabel; docstring loclabel;

View File

@ -67,7 +67,8 @@ public:
/// \return formatted BibTeX data for a citation label /// \return formatted BibTeX data for a citation label
docstring const getLabel(BibTeXInfo const * const xref, docstring const getLabel(BibTeXInfo const * const xref,
Buffer const & buf, docstring const & format, bool richtext, Buffer const & buf, docstring const & format, bool richtext,
docstring before, docstring after, docstring dialog, bool next = false) const; const docstring & before, const docstring & after,
const docstring & dialog, bool next = false) const;
/// ///
const_iterator find(docstring const & f) const { return bimap_.find(f); } const_iterator find(docstring const & f) const { return bimap_.find(f); }
/// ///
@ -203,9 +204,8 @@ public:
/// \return formatted BibTeX data for citation labels. /// \return formatted BibTeX data for citation labels.
/// Citation labels can have more than one key. /// Citation labels can have more than one key.
docstring const getLabel(std::vector<docstring> const & keys, docstring const getLabel(std::vector<docstring> const & keys,
Buffer const & buf, std::string const & style, bool richtext = false, Buffer const & buf, std::string const & style, bool richtext,
docstring const & before = docstring(), docstring const & before, docstring const & after,
docstring const & after = docstring(),
docstring const & dialog = docstring()) const; docstring const & dialog = docstring()) const;
/// Is this a reference from a bibtex database /// Is this a reference from a bibtex database
/// or from a bibliography environment? /// or from a bibliography environment?
@ -214,9 +214,8 @@ public:
/// list of keys, using either numerical or author-year style depending /// list of keys, using either numerical or author-year style depending
/// upon the active engine. /// upon the active engine.
std::vector<docstring> const getCiteStrings(std::vector<docstring> const & keys, std::vector<docstring> const getCiteStrings(std::vector<docstring> const & keys,
std::vector<CitationStyle> const & styles, Buffer const & buf, bool richtext = false, std::vector<CitationStyle> const & styles, Buffer const & buf, bool richtext,
docstring const & before = docstring(), docstring const & before, docstring const & after,
docstring const & after = docstring(),
docstring const & dialog = docstring()) const; docstring const & dialog = docstring()) const;
/// Collects the cited entries from buf. /// Collects the cited entries from buf.
void collectCitedEntries(Buffer const & buf); void collectCitedEntries(Buffer const & buf);