anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-11-22 10:00:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Make undo action no-ops when the buffer is read-only

Browse Source 
Since the buffer cannot be modified, there is no point to record changes.
Avoids marking buffer dirty after running "inset-forall".
This commit is contained in:
Jean-Marc Lasgouttes 2022-02-20 19:48:13 +01:00
parent a90a1aed06
commit bfe9818116
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/Undo.cpp
View File

@ -374,6 +374,9 @@ void Undo::Private::recordUndo(UndoKind kind,
LASSERT(first_pit <= cell.lastpit(), return); LASSERT(first_pit <= cell.lastpit(), return);
LASSERT(last_pit <= cell.lastpit(), return); LASSERT(last_pit <= cell.lastpit(), return);
if (buffer_.isReadonly())
return;
doRecordUndo(kind, cell, first_pit, last_pit, cur, doRecordUndo(kind, cell, first_pit, last_pit, cur,
undostack_); undostack_);
@ -408,6 +411,9 @@ void Undo::Private::doRecordUndoBufferParams(CursorData const & cur_before,
void Undo::Private::recordUndoBufferParams(CursorData const & cur) void Undo::Private::recordUndoBufferParams(CursorData const & cur)
{ {
if (buffer_.isReadonly())
return;
doRecordUndoBufferParams(cur, undostack_); doRecordUndoBufferParams(cur, undostack_);
// next time we'll try again to combine entries if possible // next time we'll try again to combine entries if possible
@ -517,6 +523,9 @@ void Undo::Private::doUndoRedoAction(CursorData & cur, UndoElementStack & stack,
bool Undo::Private::undoRedoAction(CursorData & cur, bool isUndoOperation) bool Undo::Private::undoRedoAction(CursorData & cur, bool isUndoOperation)
{ {
if (buffer_.isReadonly())
return false;
undo_finished_ = true; undo_finished_ = true;
UndoElementStack & stack = isUndoOperation ? undostack_ : redostack_; UndoElementStack & stack = isUndoOperation ? undostack_ : redostack_;