anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-11-22 01:59:02 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Stephan has checked that caching is still needed on macOS

Browse Source 
Basically removing the cache makes getTextLayout 17x more expensive on
a simple test of scrolling through the Tutorial.
This commit is contained in:
Jean-Marc Lasgouttes 2022-11-25 12:44:56 +01:00
parent 04cf47f46c
commit cd5fe091d2
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
TODO.killqt4
View File

@ -1,5 +1,4 @@
Things left to do after killing Qt4 (obtained by grepping for Qt4 and 'Qt 4'): Things left to do after killing Qt4 (obtained by grepping for Qt4 and 'Qt 4'):
* look at the FIXME KILLQT4 comments in src/ and resolve them
* update INSTALL.cmake * update INSTALL.cmake
* update INSTALL.MacOSX * update INSTALL.MacOSX
* update cmake * update cmake

3
src/frontends/qt/GuiFontMetrics.cpp
View File

@ -84,7 +84,8 @@ int const breakstr_cache_max_cost = 10 * 1024 * 1024;
// Qt 5.x already has its own caching of QTextLayout objects // Qt 5.x already has its own caching of QTextLayout objects
// but it does not seem to work well on MacOS X. // but it does not seem to work well on MacOS X.
#if defined(Q_OS_MAC) #if defined(Q_OS_MAC)
//FIXME KILLQT4: check wether setting the cache to 0 hurts on macOS // For some reason, the built-in cache of QTextLayout does not work or
// exist on macOS.
// Limit qtextlayout_cache_ size to 500 elements (we do not know the // Limit qtextlayout_cache_ size to 500 elements (we do not know the
// size of the QTextLayout objects anyway). // size of the QTextLayout objects anyway).
int const qtextlayout_cache_max_size = 500; int const qtextlayout_cache_max_size = 500;