anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-12-22 13:18:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Submenus now expand even if all items are disabled

Browse Source 
As stated in the Apple HIG[1] (via JMarc):

  Ensure that a submenu’s title is undimmed even when all its commands
  are unavailable. As with menu titles, it’s important for users to be
  able to view a submenu’s contents, even if none of them are
  available in the current context.

[1]
https://developer.apple.com/library/mac/documentation/UserExperience/Conceptual/AppleHIGuidelines/Menus/Menus.html#//apple_ref/doc/uid/TP30000356-TP6
This commit is contained in:
Scott Kostyshak 2014-02-21 10:26:36 -05:00
parent fb05011ad0
commit d449e7e64e
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/frontends/qt4/Menus.cpp
View File

@ -418,8 +418,7 @@ void MenuDefinition::addWithStatusCheck(MenuItem const & i)
// Only these kind of items affect the status of the submenu // Only these kind of items affect the status of the submenu
if ((cit->kind() == MenuItem::Command if ((cit->kind() == MenuItem::Command
|| cit->kind() == MenuItem::Submenu || cit->kind() == MenuItem::Submenu
|| cit->kind() == MenuItem::Help) || cit->kind() == MenuItem::Help)) {
&& cit->status().enabled()) {
enabled = true; enabled = true;
break; break;
} }